search

Dahlgren / arma-server-web-admin

Web based server manager for Arma
MIT License
125 stars 47 forks source link

Race condition when launching server #184

Closed Tirpitz93 closed 3 years ago

Tirpitz93 commented 3 years ago

Hello again, Another issue I encountered (not virtual server branch), when launching a server with headless clients, sometimes the HCs launch first and never release the cache lock. this means the server never starts.

Dahlgren commented 3 years ago

Interesting. Some HC regressions were introduced around Arma 3 patch 1.96 or 1.98. If the server is not yet fully launched when they try to connect they can get stuck in connecting state.

Tirpitz93 commented 3 years ago

would it be possible to delay HC launch till after server is up? I should also state we started noticing something funny from about 1.98, but its now almost unusable with HCs, since yesterdays hotfix

Dahlgren commented 3 years ago

Ideally it would probably wait until steam queries starts responding, should be quite simple to delay the launch there.

I've also had some ideas around letting HCs be dynamically changed during mission if there's a need for fewer/more.

We've sometimes had issues were a mission maker decided to have too many HCs which backfired mid mission. Or forgotten to launch the server with HCs. Being able to scale up/down would solve solve such issues.

Tirpitz93 commented 3 years ago

Ideally it would probably wait until steam queries starts responding, should be quite simple to delay the launch there.

that is what I was thinking, I am not sure what logic the panel currently uses for up detection. but that would probably be sufficient.

I've also had some ideas around letting HCs be dynamically changed during mission if there's a need for fewer/more.

Sounds interesting, its not something we have come across, at least not regularly

We've sometimes had issues were a mission maker decided to have too many HCs which backfired mid mission. Or forgotten to launch the server with HCs. Being able to scale up/down would solve solve such issues.

can't you just kick the HC?

Tirpitz93 commented 3 years ago

I was only able to reproduce the error on my local machine when loading significant amounts of mods. when loading a vanilla server is seems to load fine

Tirpitz93 commented 3 years ago

Seems to only on be an issue on "performance and profiling" branch

Dahlgren commented 3 years ago

We've been able to repro it with the 2.04 perf binary, I'll make some changes to the startup order