Dahlgren / arma-server-web-admin

Web based server manager for Arma

MIT License

125 stars 47 forks source link

Timezone and naming of logfiles #196

Closed formtapez closed 3 years ago

formtapez commented 3 years ago

In lib/logs.js Date().toISOString() is used to generate a datestring for the logfiles. The timezone for it is always UTC. Could we have a local timezone here?

Also: What happens when you enable multiple servers for autostart? Will multiple logfiles "collide" with each other because of a same name? As a solution could we have the filename suffixed with the actual servername?

Dahlgren commented 3 years ago

Please leave feedback here https://github.com/Dahlgren/arma-server-web-admin/pull/180

formtapez commented 3 years ago

That doesn´t cover any of the two issues.

Dahlgren commented 3 years ago

Fixed in #197 and #198

formtapez commented 3 years ago

197 works great, thanks.

198 I would prefer to have the correct timestamp in the filename itself.

Dahlgren commented 3 years ago

UTC is the most correct as admins might be from multiple timezones. It also takes care of winter vs summer time. UTC never lies :)