Daksh777 / TakeABreak

Tackle procrastination by using self-destructing tabs and boost your productivity.
https://breaks.eu.org
GNU Affero General Public License v3.0
74 stars 114 forks source link

Fixed the add button, optimized the code, added some documentation, a… #173

Closed mtalhakhan357 closed 7 months ago

mtalhakhan357 commented 1 year ago

//…nd made necessary improvements

πŸ› οΈ Trying to fix Issue #152

Fixed issue with the addsites function and optimixed it, It was not working when i forked the project so i fixed it. The console was giving the following issue when adding or deleting a custom site: main.js:32 Uncaught (in promise) TypeError: Cannot set properties of null (setting 'value') at addSite (main.js:32:359) at saAddSite (main.js:28:142)

πŸ‘¨β€πŸ’» Changes proposed

βœ”οΈ Check List (Check all the applicable boxes)

πŸ“· Screenshots

πŸ“„ Note to reviewers (optional)

mtalhakhan357 commented 1 year ago

On my forked project, there seems to be an issue with the functionality. For instance, the default sites are not available, and when attempting to access the custom sites, the button isn't redirecting me to the loading.html. Delete button is also not working.

Could you please look into this matter and provide any necessary guidance or assistance to resolve these issues? Is there any database that i have to make? or missing some files?

mtalhakhan357 commented 1 year ago

Can you merge it now?

Daksh777 commented 10 months ago

Hey @mtalhakhan357, apologies for such a long delay. I've been occupied both in work and personal life and couldn't check your PR.

I'll review it today and get back to you, thanks a lot :)