DalgoT4D / DDP_backend

Django app for the DDP platform
GNU Affero General Public License v3.0
12 stars 41 forks source link

production webhook failure fix - sentry #857

Closed Ishankoradia closed 2 months ago

Ishankoradia commented 2 months ago

@fatchat the production sentry bug was in the webhook where it was fetching logs for a failed run. Since we (huzaif's logs pagination PR) updated the flow run logs api , we forgot to change things here.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.54%. Comparing base (2d0e25d) to head (afedc91). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
ddpui/api/pipeline_api.py 0.00% 2 Missing :warning:
ddpui/ddpprefect/prefect_service.py 85.71% 2 Missing :warning:
ddpui/celeryworkers/tasks.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #857 +/- ## ========================================== + Coverage 74.40% 74.54% +0.14% ========================================== Files 192 192 Lines 7967 7968 +1 ========================================== + Hits 5928 5940 +12 + Misses 2039 2028 -11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.