search

DanBloomberg / leptonica

Leptonica is an open source library containing software that is broadly useful for image processing and image analysis applications. The official github repository for Leptonica is: danbloomberg/leptonica. See leptonica.org for more documentation.
Other
1.77k stars 389 forks source link

Add GitHub action for build and test on macOS #716

Closed stweil closed 1 year ago

stweil commented 1 year ago

See this example for the new action.

DanBloomberg commented 1 year ago

Elegant!!

I looked at the example, and saw it did 147 tests. I've been getting 146 when run locally using alltests_reg. Comparing the set, I found that numa3_reg.c had been omitted from alltests_reg, for no good reason. So I'll add it.

stweil commented 1 year ago

@DanBloomberg, I wonder whether the new action really should be triggered by every pull request and git push. In addition it can be triggered manually by project maintainers (url). Each action run uses two CPU cores for 12 minutes, one for macOS 12 and one for macOS 13.

Maybe it would be sufficient to run only on macOS 13 by default, so macOS 12 would only be tested when that was requested manually. What do you think?

DanBloomberg commented 1 year ago

Running by default only with macOS 13 is fine with me.

Considering possible overuse of github resources, what do you think about the fuzzing that is run on every git push? (I don't know if it is run with PRs)

stweil commented 1 year ago

The fuzzing action is only triggered by pull requests, see the code. It typically runs for about 30 minutes (see history). That looks like a waste of resources, for example electrical energy, because Google's OSS-Fuzz also runs fuzzers for Leptonica (not only for a few minutes which won't find issues, but really long) and reports build errors by e-mail. @AdamKorcz, what do you think?