Dangabit / pe

0 stars 0 forks source link

Add command error message can be clearer for age #10

Open Dangabit opened 1 year ago

Dangabit commented 1 year ago

A valid integer is inputted. Perhaps the error message can be more concise (eg. the exact range)

image.png

nus-se-script commented 1 year ago

Team's Response

The nature of the problem is that the age is too large to be reasonable. The error message is only a cosmetic issue.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Age of too large number is acceptable

Screenshot 2023-04-14 at 2.45.33 PM.png


[original: nus-cs2103-AY2223S2/pe-interim#3454] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Where should we draw the line then?

If we set the line to 100, then you could say, well, there are pilots of age 100. If we increase it, you could say that well, that's impossible. The boundary is not very clear, and that's why we didn't do this validation. If we set this to 200, then you could argue that 199 is not possible.

We feel that we don't have the responsibility here to limit the age. It is the user's responsibility to make sure that the correct age is inputted. Granted, there might be typos, but you can simply reenter the field later on if you find such typos.

When does validation matter? Validation matters when other parts of the software rely on the data. If the data input is wrong, then it will crash the app. This is when input validation matters. We should validate the emails because if they don't follow a standard, they are guaranteed to be wrong. That does not mean that every email input will be correct -- many are simply incorrect emails that will bounce back. Entering the correct email, therefore, should be the user's responsibility, but not the software designer's -- especially given that when the software does not rely on the email being correct.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: My issue is fundamentally different from the "original" issue. I was looking at the fact that they said integer and my integer, while valid, did not work.


## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]