Closed calithameridi closed 1 week ago
@lraithel15133 is working on it
Thanks for the suggestion.
There is ongoing work in the background to add a list of common stepsticks and their sense resistors, so users can choose the exact hardware they have.
I've added a warning for now, as I do not want to break existing configurations.
sense_resistor now has a warning, and soon, we will have step stick lookup tables, so I am closing this. I don't feel pullup_resistor is as dangerous as sense_resistor, so we won't change that now and might revisit this in the future. Thanks
In certain configuration parameters, Klipper assumes default values if the field is omitted by the user or not explicitly specified. This has led to some ... concerning user error scenarios in practice. Take the following example:
Affected fields include 'sense_resistor' in [tmc] and 'pullup_resistor' in [temperature_sensor]. There may be other examples of this behavior that I haven't thought of at this moment.
This change may cause headaches for end users who must fill in the formerly optional values but safety comes before inconvenience.