search

Daniel-KM / Omeka-S-module-IiifServer

IIIF Server is a module for Omeka S that adds the IIIF specifications to serve any images and medias.
Other
17 stars 11 forks source link

Item manifest: Empty href in descriptive metadata link in #23

Closed flamsens closed 4 years ago

flamsens commented 4 years ago

IiifServer version 3.5.16 - Option 'Link for descriptive metadata' enabled

When an item has a value referencing another item, the resulting metadata in the IIIF manifest contains an empty link (empty href):

{ label: "Source", value: "<a class="resource-link" href=""><span class="resource-name">Punch, or the London Charivari</span></a>" }

I fixed this by altering function 'valuesAsHtml' in 'scr/View/Helper/IiifManifest.php':

old:

if ($v->type() === 'resource') { $r = $v->valueResource();

new:

if ( ( $v->type() === 'resource' || $v->type() === 'resource:item' ) && $r = $v->valueResource() ) {

Daniel-KM commented 4 years ago

Thanks, it's integrated and many other things in version 3.6.0.beta-4. It requires last versions of modules Image Server, UniversalViewer or Mirador too.