Daniel-t / node-red-contrib-aws

A collection of Node-RED nodes for AWS.
Apache License 2.0
57 stars 59 forks source link

Firehose support #41

Closed myco closed 6 years ago

myco commented 6 years ago

Hi, do you have Kinesis Firehose support in your plans?

Daniel-t commented 6 years ago

Not yet, but its easy to add new nodes now. I'll add it to the list for a soonish release.

If your keen, you can build it by running gen_scripts/run_build.js , copy the firehose html and js scripts to the parent directory and updating the package.json. If it works for you please issue a pull request and I'll bring it straight in.

myco commented 6 years ago

I made initial support for firehose. For now only putRecord method, because I created it manually. Didn't know how to run gen_scripts/run_build.js Is there some instruction about it?

Pull Request: #42

Daniel-t commented 6 years ago

Added initial Firehose support, could you please test it and confirm if its functional.

This does not use msg.Payload as Record.

myco commented 6 years ago

So where is it? I can not find any correlated commit.

I think it's important to pass somehow records from other blocks. It doesn't need to be msg.Payload. Can be msg.Record instead.

BTW. According to documentation https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/Firehose.html#putRecord-property putRecord takes 'Record' as { Data: new Buffer(...) }

Daniel-t commented 6 years ago

Ok no idea what happened there. I’ll push another version today.

You will be able to use Record to pass details in for those functions that support it.

myco commented 6 years ago

OK, it works! { Data: new Buffer(payload) }

Thank you