Danp2 / au3WebDriver

Web Driver UDF for AutoIt
MIT License
108 stars 23 forks source link

Expand _WD_FrameList with Delay and Timeout parameters #456

Closed mlipok closed 1 year ago

mlipok commented 1 year ago

Pull request

Proposed changes

this change give user possibility to provide they own $iDelay and $iTimeout to have ability to wait for web page will be entirely loaded including all frames.

Checklist

Types of changes

What is the current behavior?

no way to use custom $iDelay and $iTimeout settings in _WD_FrameList() calls

What is the new behavior?

and now you can do this easily

Additional context

https://github.com/Danp2/au3WebDriver/issues/420

System under test

not related

mlipok commented 1 year ago

@Danp2 if you have only to request changes in the header or other cosmetic changes just commit them, and I will be able to take a look and agree or disagree.

mlipok commented 1 year ago

Tested with DemoFrames on FireFox and IEDriver

mlipok commented 1 year ago

Tested again DemoFrames. All is ok. But...

mlipok commented 1 year ago

Small Update wd_demo.au3 And as for me it is all fine. You can merge.

Danp2 commented 1 year ago

You can merge.

Nope. Your last commit has a problem.

mlipok commented 1 year ago

You can merge.

Nope. Your last commit has a problem.

wd_demo.au3 fix