IE's Pipe plus QS' Fluid Trash Can = CME upon world load

Garash2k commented 7 months ago

Bug Description

This simple 3 block setup, using Immersive Engineering and Quantum Storage, causes the world to become unloadable. A crash will occur every time upon loading it. Metal Barrel (IE) > Fluid Pipe (IE) > Fluid Trash Can (QS)

Exception in server tick loop - java.util.ConcurrentModificationException

Note: The in-game restore backup feature errors out and It seems to corrupt the JourneyMap data as well, I had to both manually restore a backup and delete the world's JourneyMap data to fix my world.

I'm not 100% sure if it's either a DarkPacks or IE bug, but an unloadable world is a really catastrophical bug, so I figured I'd report it.

Addendum: while this bug occurs with Quantum Storage's Fluid Trash Can, it turns out that Cyclic's Trash Void works A-OK, go figure.

Did this behavior use to work in the previous version?

N/A

Steps to Reproduce (for bugs)

Create a new world
/advancement grant playerName everything
Build a 3 block high contraption of Metal Barrel (IE) > Fluid Pipe (IE) > Fluid Trash Can (QS.)
No need to fill the Barrel, it'll crash just the same if it's Empty
Save and Quit then Load the World

Logs

Client/Server Log: 2024-04-21-7.log
Crash Log: crash-2024-04-21_10.07.43-server.txt

Client Information

Modpack Version: 3.2.1
Java Version: 1.8.0_51
Launcher Used: Forge Latest
Memory Allocated: 16 000MB
Server/LAN/Single Player: Single Player
Optifine Installed: Yes, but the world also crashes without
Shaders Enabled: Yes

World Information

Modpack Version world created in: 3.2.1
Additional Content Installed: 1 single other mod, FullscreenWindowed-1.12-1.6.0

Garash2k commented 7 months ago

oh god it's so much worse, it's not related to the Tank or redstone at all!

Garash2k commented 7 months ago

@sam-kirby possible and/or worth fixing in SevPatches?

sam-kirby commented 7 months ago

I haven't had a chance to look into this at all yet, but the last release of SevPatches (which hasn't made it into SevTech yet) fixed a CME during chunk loading - you could give it a try and see if this is actually that same issue in a different hat?

https://www.curseforge.com/minecraft/mc-mods/sevpatches/files/5142938

Garash2k commented 7 months ago

Good news, using that SevPatches 1.12.0-15 release instead of the 1.9-10 I was using, my formerly bricked test worlds loaded without issues, so it does seem like it's the same fixed issue, kudos!

DarkPacks / SevTech-Ages