Darkhax-Minecraft / Open-Loader

An open source resource and data loader for Minecraft.
GNU Lesser General Public License v2.1
19 stars 7 forks source link

en_us language changes are not picked up on the server #20

Closed Hubry closed 2 years ago

Hubry commented 2 years ago

We have a resource pack that replaces some advancement names - however while they show up on the clients correctly:

"A fork in the road"

...Discord chat bridge mods use the translations from the server, and that's not loaded there:

"This is the Wae"

In case of modpacks adding new advancements purely with Open Loader, they show up like this:

obraz

The top two screenshots are from an in-dev modpack for 1.18.1 made by a group of my friends, bottom screenshot is from Vazkii's patreon server running Crucial 2 (1.16.5).

Darkhax commented 2 years ago

After reviewing the code for server side localizations, I think the right way to achieve this is by including your language entries in a datapack as well. The Forge code appears to load language data from all data packs rather than just mods. So including the files in the assets file as you would with a mod should work fine.

It appears that Fabric API and QSL do not have analogous features and initializing my own resource manager for this sounds like a horrible idea. I think the best approach here would be to let them implement this feature.