Darkpeninsula / Darkcore

DarkCore Project is a no-profit Open Source community. **We're looking for contributors** to keep this project up-to-date !!
http://project.darkpeninsula.eu/
GNU Affero General Public License v3.0
39 stars 25 forks source link

Grim Batol, WoW error on Drahga and Erudax #56

Closed Walkum closed 12 years ago

Walkum commented 12 years ago

It is very easy to reproduce. Fight with Drahga, and when he is 30% and go to Valiona, pum WoW error.

Erudax is the same, when Erudax go to the center for cast one spell, pum WoW error.

I think that is caused by the MovementInforms, but I don't know why is caused.

The code where Drahga give WoW error:

    void MovementInform(uint32 type, uint32 id)
    {
        if (type != POINT_MOTION_TYPE)
            return;

        switch (id)
        {
            case POINT_VALIONA_FLY_IN_THE_AIR:
                currentWaypoint++;
                if(currentWaypoint < 3) // You can extend the Waypoints by yourself if you want
                    me->GetMotionMaster()->MovePoint(POINT_VALIONA_FLY_IN_THE_AIR, position[currentWaypoint]);
                else
                    me->GetMotionMaster()->MoveLand(POINT_VALIONA_LAND, position[3],5);
                break;

The code where Erudax give WoW error:

    void MovementInform(uint32 type, uint32 id)
    {
        if (type == POINT_MOTION_TYPE)
        {
            switch (id)
            {
                case POINT_ERUDAX_IS_AT_STALKER:
                    DoCast(SPELL_SHADOW_GALE_VISUAL);
                    ShouldSummonAdds = true;
                    break;
                default:
                    break;
            }
        }
    }
Naios commented 12 years ago

I didn't recognized any wowerror if you are fighting against dragha but the heroic version of erduax ability "shadow gale" causes wowerrors because the target selection isn't working properly. I think he hits every creature in the instance with that spell.

If you want to use this scripts with skyfire you have to convert movement inform and move point to db waypoints.

msholto commented 12 years ago

http://pastebin.com/85httj3v ;-)

Darkrabbit commented 12 years ago

fixed in https://github.com/Darkpeninsula/Darkcore/commit/23b028ebe845330a80fb4426018efc9064c6e461

Walkum commented 12 years ago

wow error persist yet @msholto @Darkrabbit