DarkstarProject / darkstar

DEPRECATED - FFXI Server Emulator - See Project Topaz
https://github.com/project-topaz/topaz
GNU General Public License v3.0
455 stars 550 forks source link

Tredecim Scythe #6424

Open Caelic opened 4 years ago

Caelic commented 4 years ago

the 13th hit guaranteed critical is not coded yet so here it is. wiki says it shouldnt count WS hits and this code follows that, this is just for autoattacks. wiki says it should save hit count when zoning but that will require adding an extra field within the database and i didn't want to clutter the database more to add "cross-zone memory" just seems unimportant. upon zoning the count is just set to 0.

Caelic commented 4 years ago

this is the only item in the game that tracks x hits. if you want to generalize it then you have to set up a memory system so that every item with the mod will remember its own hit counter and not interfere with another item's hit counter. it's an unnecessary amount of work to generalize it if it's the only item that will ever use the latent.

zach2good commented 4 years ago

I wonder if it's worth adding a new member to CCharEntity when only the population that equips the scythe at least once will ever need it, there's nothing else as item-specific in CCharEntity. As much as forever-CharVars are frowned upon, they could be another option to track the hit counter.