search

DasSauerkraut / calendar-weather

A module for FoundryVTT that adds a calendar widget with weather, moons cycles, and a customizable calendar.
Apache License 2.0
19 stars 26 forks source link

Calendar "auto transition to darkness" option causes map to flicker #165

Open Norc opened 4 years ago

Norc commented 4 years ago

Reporting on behalf of someone else, so I apologize for any missing info:

Per Honkou#4442

Similar question to Tandera. Has anyone had a problem with blinking (constantly reloading) scene during night? I'm guessing weather/calendar is to blame.. well nevermind. Apparently my wife fixed it by turning off auto transitioning to day/night in the scene configuration. So probably the calendar mod is still the culprit but at least it works

Honkou commented 4 years ago

Hi, that's me.

I'm on Foundry 0.6.6, About Time 0.1.53, Calendar/Weather 2.6.0, issue keeps persisting wth other modules off.

During night time, the scene keeps reloading every 1s, causing the whole screen to flicker. What's weird, is that it doesn't do that when the calendar timer is paused. Turning off the scene night cycle in the scene configuration solved the issue, but it requires changing lights manually.

DasSauerkraut commented 4 years ago

This is due to some probably outdated code in how the day/night cycle is handled. When the darkness slider was first implemented, the canvas had to be 'reset' everytime it was changed. This means that whenever the darkness increases because of a time update, the canvas can flicker, especially on slower computers. I need to take another look at it, because there's a chance that the particular issue that forced this workaround has been patched.