search

DasSauerkraut / calendar-weather

A module for FoundryVTT that adds a calendar widget with weather, moons cycles, and a customizable calendar.
Apache License 2.0
19 stars 26 forks source link

Template updates #214

Open Geekswordsman opened 3 years ago

Geekswordsman commented 3 years ago

There is a bug in Foundry v0.8.x's FormApplication._renderInner in which it no longer accurately sets this.form if the form is not the first element in the template. This update simply moves the styles to the end of the templates, thereby creating a local hotfix for the bug while remaining backwards compatible.

jstebenne commented 3 years ago

Can you remove the code reorganization out of the bugfix to make it easier to see what exactly the bugfix is for the 0.8.x update? At the very least, the bugfix and code reorganization should be in two different commits. At best, they should be in two different pull requests.

Geekswordsman commented 3 years ago

The only bugfix is the code reorganization.

The bug in core Foundry revolves around a FormApplication in which the form element is not the first element.

So the fix is literally just moving the style tags down below the form. That's it.

hwfwalton commented 3 years ago

Any reason to hold off merging at this point?

jstebenne commented 3 years ago

@hwfwalton No, but the branch can only be merged by the repository's owner, and he has not been around lately.

The readme also says the project is no longer maintained. So I created a new repo here: https://gitlab.com/jstebenne/foundryvtt-calendar-weather.

Geekswordsman will copy his changes over there, and we will keep it up to date in that new repo. We should be added to Foundry's module list at some point, but I have no ETA on that.