Dashticz / dashticz_v2

Alternative dashboard for Domoticz
107 stars 59 forks source link

Fix for selector Level Names (Base 64) #329

Closed DewGew closed 6 years ago

DewGew commented 6 years ago

I dont know if this will work on erlier versions of domoticz (mine is 3.9540). Maybe someone can try this first?

lokonli commented 6 years ago

I tried. Doesn't work with my version of Domoticz: 3.8850, which is from January 2018.

When was the change to/from base64 encoding of the selector Level Names?

I think Domoticz made the change in March 2017: https://www.domoticz.com/forum/viewtopic.php?t=16692#p124510

That means that the actual versions of Domoticz are without base64 encoding. I propose to revert this PR.

DewGew commented 6 years ago

I think it has something to do with this commit https://github.com/domoticz/domoticz/commit/16731807489d518b1134346242bb7c04db3d9dd0

lokonli commented 6 years ago

You're right. Some more complaints on github: https://github.com/domoticz/domoticz/issues/2454

What shall we do? Probably the old style levelnames contain the '|' character. We could test on that one. If it's found then it's not base64 encoded.

lokonli commented 6 years ago

This works for me: if (device['LevelNames'].includes('|')) { names=device['LevelNames'].split('|'); } else { names=window.atob(device['LevelNames']).split('|'); }

DewGew commented 6 years ago

I can make a Domoticz version checker. If the user has version above 3.9476 encoding is true..

lokonli commented 6 years ago

That would be great!

Op do 7 jun. 2018 23:18 schreef DewGew notifications@github.com:

I can make a Domoticz version checker. If the user has version above 3.9476 encoding is true..

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Dashticz/dashticz_v2/pull/329#issuecomment-395568395, or mute the thread https://github.com/notifications/unsubscribe-auth/AVyyD3MIrvb-lML1lrXDo0ppB7qVAoPcks5t6Zi2gaJpZM4UeXQf .

DewGew commented 6 years ago

merged #331