search

DataBiosphere / dsub

Open-source command-line tool to run batch computing tasks and workflows on backend services such as Google Cloud.
Apache License 2.0
265 stars 44 forks source link

Feature/extend batch support #285

Closed mccstan closed 6 months ago

mccstan commented 8 months ago

Fix ignored configs when submitting jobs against Google Batch : Doing :

mccstan commented 8 months ago

Thanks for reviewing @wnojopra

Feel free to integrate and share when it is possible.

I updated my linter to user 2 space style indent, but there is still some spaces remaining, I had to manually remove them.

Thanks.

amircs commented 8 months ago

Great work, @mccstan! Hi @wnojopra, would it be possible for you to expedite the integration? I really appreciate your support!

wnojopra commented 8 months ago

Hi @mccstan! We'd love to incorporate your work into dsub and improve our ability to take in community contributions. We need to get our CONTRIBUTING doc updated, but in the meantime, can you please review and sign our Contributor License Agreement? You can send it to our IP team at ip@verily.com. Thanks!

mccstan commented 8 months ago

[image: Fichier PDF] [externally shared] Verily Individual… https://drive.google.com/file/d/1N4RXOue_OLnG4jOGBZWDNtQAmP0dlr19/view?usp=drivesdk

Le lun. 25 mars 2024 à 19:09, Willy Nojopranoto @.***> a écrit :

Hi @mccstan https://github.com/mccstan! We'd love to incorporate your work into dsub and improve our ability to take in community contributions. We need to get our CONTRIBUTING doc https://github.com/DataBiosphere/dsub/blob/main/CONTRIBUTING.md updated, but in the meantime, can you please review and sign our Contributor License Agreement https://docs.google.com/document/d/1Yc-z59DQKRqiqpVgHcIHC3xhfwm3DoPmpc9eFwr_J8c/edit?resourcekey=0-k9NMsHVrhlafbKiAIE9GoA&tab=t.0#heading=h.eqi47wqyyinr? You can send it to our IP team at @.*** Thanks!

— Reply to this email directly, view it on GitHub https://github.com/DataBiosphere/dsub/pull/285#issuecomment-2018605855, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD3ILBEWNSSDJGR75AZDX6DY2BR5TAVCNFSM6AAAAABELMKH3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJYGYYDKOBVGU . You are receiving this because you were mentioned.Message ID: @.***>

nithinjoshy commented 7 months ago

Hi,

Is there a timeline on when these features might be added and officially released?

Thanks!

wnojopra commented 7 months ago

We've recently passed the IP contributors guidelines, and are now capable of accepting this PR into our internal repo. The next step is for me to run this through our tests and possibly add tests. Stay tuned, and thanks again to everyone for the interest and support.

mccstan commented 7 months ago

That's great news!

Le ven. 12 avr. 2024 à 01:55, Willy Nojopranoto @.***> a écrit :

We've recently passed the IP contributors guidelines, and are now capable of accepting this PR into our internal repo. The next step is for me to run this through our tests and possibly add tests. Stay tuned, and thanks again to everyone for the interest and support.

— Reply to this email directly, view it on GitHub https://github.com/DataBiosphere/dsub/pull/285#issuecomment-2050734035, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD3ILBAIVTMPGR533RIM7ETY44PI5AVCNFSM6AAAAABELMKH3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJQG4ZTIMBTGU . You are receiving this because you were mentioned.Message ID: @.***>

wnojopra commented 7 months ago

Just a quick update on this - we have this PR working internally with tests. A release with this update is coming soon.

wnojopra commented 6 months ago

Closing this PR as this has now been included with the latest release

Once again, thank you for the PR. We very much appreciate community support.