In my local testing, this significantly improves FTP performance. (Previously an existence check on a small text file on an insecure FTP server took around 5 seconds, though I'm unsure why it would take so long originally)
[ ] New functions or classes without informative docstrings.
[ ] Changes to semantics not reflected in the relevant docstrings.
[ ] New or changed command line options for Toil workflows that are not reflected in docs/running/{cliOptions,cwl,wdl}.rst
[ ] New features without tests.
[ ] Comment on the lines of code where problems exist with a review comment. You can shift-click the line numbers in the diff to select multiple lines.
[ ] Finish the review with an overall description of your opinion.
Merger Checklist
[ ] Make sure the PR passes tests.
[ ] Make sure the PR has been reviewed since its last modification. If not, review it.
[ ] Merge with the Github "Squash and merge" feature.
[ ] If there are multiple authors' commits, add Co-authored-by to give credit to all contributing authors.
[ ] Copy its recommended changelog entry to the Draft Changelog.
[ ] Append the issue number in parentheses to the changelog entry.
Closes #5134
Also turns all url_exists requests and size requests to HEAD requests instead, as mentioned here: https://github.com/DataBiosphere/toil/issues/5114#issuecomment-2392527695
In my local testing, this significantly improves FTP performance. (Previously an existence check on a small text file on an insecure FTP server took around 5 seconds, though I'm unsure why it would take so long originally)
Changelog Entry
To be copied to the draft changelog by merger:
Reviewer Checklist
issues/XXXX-fix-the-thing
in the Toil repo, or from an external repo.camelCase
that want to be insnake_case
.docs/running/{cliOptions,cwl,wdl}.rst
Merger Checklist