DataDog / datadog-cloudformation-macro

CloudFormation Macros by Datadog
Apache License 2.0
14 stars 22 forks source link

Add arch invalid error checking #107

Closed TophrC-dd closed 8 months ago

TophrC-dd commented 1 year ago

What does this PR do?

This pr adds a check to validate if a proper architecture is defined when the layer is being added. If an invalid architecture is specified an error is given to the user that it's invalid with a readout of the architecture they tried using.

Motivation

An escalation came through where a customer was confused why their code wasn't being deployed. it turned out they had mapping in place to substitute the architecture against their own non-standard versions. this mapping didn't work so the runtime value was becoming set as undefined

Testing Guidelines

I tested the code block in chrome's dev tools to test functionality ensuring no syntax errors.

Additional Notes

N/A

Types of changes

Check all that apply

duncanista commented 8 months ago

Closing due to being stale. Feel free to re-open if issue persist.