DataDog / datadog-cloudformation-macro

CloudFormation Macros by Datadog
Apache License 2.0
14 stars 22 forks source link

feat: Replace hub with gh cli #114

Closed astuyve closed 9 months ago

astuyve commented 9 months ago

What does this PR do?

hub requires personal access tokens, which we shouldn't use anymore. It's also a community project.

We can do the exact same thing with the gh command line tool https://cli.github.com/

this is a drop in replacement and was used to release 0.9.0

Motivation

Testing Guidelines

Additional Notes

Types of changes

Check all that apply

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ac51d24) 86.43% compared to head (81e2ead) 86.43%.

:exclamation: Current head 81e2ead differs from pull request most recent head 6dce3b9. Consider uploading reports for the commit 6dce3b9 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #114 +/- ## ======================================= Coverage 86.43% 86.43% ======================================= Files 8 8 Lines 612 612 Branches 153 153 ======================================= Hits 529 529 Misses 72 72 Partials 11 11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.