DataDog / datadog-cloudformation-macro

CloudFormation Macros by Datadog
Apache License 2.0
14 stars 22 forks source link

End of support for Node.js v16.x #120

Closed Omar-Bishtawi closed 5 months ago

Omar-Bishtawi commented 5 months ago

Expected Behavior

Use latest LTS Node version supported by aws (Node 20.x)

Actual Behavior

Node16.x which is being used by this macro function will soon be deprecated (Jun 12, 2024) . will there be any issue if Node20.X is used instead ?

it's simmilar change to this issue https://github.com/DataDog/datadog-cloudformation-macro/issues/71

gustavodaltoe commented 5 months ago

I see that @duncanista PR's is merged to update node to 20.x, but when I download the https://datadog-cloudformation-template.s3.amazonaws.com/aws/serverless-macro/latest.yml file, I still see that the runtime is nodejs16.x. I'm trying to update my lambdas to node20.x runtime and noticed that datadog is failing with No Lambda layer available for runtime: nodejs20.x

duncanista commented 5 months ago

Sorry for taking long to release this.

v0.12.0 is out now!

astuyve commented 1 month ago

Hey @gustavodaltoe we need to revert this as govcloud doesn't yet support node20.

We'll go to node18 for now.