feat: Support container ID field (dogstatsd 1.2) - Githubissues

DataDog / datadog-go

go dogstatsd client library for datadog

MIT License

351 stars 134 forks source link

feat: Support container ID field (dogstatsd 1.2) #250

Closed ahmed-mez closed 2 years ago

ahmed-mez commented 2 years ago

The PR does the following

Adds c:<id> field holding the container ID so the agent can attach container tags.

Brief explanation of how the new container field is handled

If DD_ENTITY_ID is set, we ignore the container field
If DD_ENTITY_ID is not set and DD_ORIGIN_DETECTION_ENABLED is not explicitly set to false or the WithoutOriginDetection() is not invoked, we try to get the app container ID by parsing /proc/self/cgroup. In case of success, the container field in will be set to .

Motivation

More granular tags (container tags instead of pod tags)
Works for containers outside of Kubernetes (e.g ECS, Fargate)
The goal of not reusing dd.internal.entity_id is to avoid parsing the value and guess the prefix on the agent side (avoid costly operations in the hot path)

Notes

Users should explicitly enable container tagging in the agent otherwise the agent ignores the container field. So even if the client sends the field automatically, the tagging won't be done without explicitly enabling it in the agent.
Cgroup parsing logic is essentially the same as in dd-trace-go
This feature requires an agent change https://github.com/DataDog/datadog-agent/pull/10659
Replaces https://github.com/DataDog/datadog-go/pull/172

ahmed-mez commented 2 years ago

Thank you for the review @hush-hush ! I'd like to get 👀 on the Agent PR before merging this one.

PTAL when you get a chance! https://github.com/DataDog/datadog-agent/pull/10659