DataDog / expo-datadog

Datadog SDK for Expo
Apache License 2.0
8 stars 5 forks source link

Support setting the Service Name on sourcemap uploads #24

Closed aaronholla closed 6 months ago

aaronholla commented 7 months ago

Is your feature request related to a problem? Please describe. When uploading sourcemaps by default the Service used will be the application's bundle identifier. This does not work for projects that set a custom serviceName in the RUM configuration during runtime initialization. For datadog to un-minify error logs the Service linked to the sourcemap needs to match the serviceName used by the RUM logs.

Describe the solution you'd like I would like to add a new config option to the plugin to allow passing a string to use as the serviceName when uploading. This option would then be passed through to the underlying gradle/ci scripts that do the uploading of source maps.

I've opened an initial PR to help make discussions of the approach a bit easier.

Describe alternatives you've considered I've explored using ENV variables to override this config. However from what I could find reading through the underlying scripts it seems only iOS supports overriding this using an ENV variable.

Additional context If possible this would be a great change to backport to the SDK 49 release. That would help existing projects who have yet to upgrade to the new SDK 50.

Also, I am not sure where I would need to edit the documentation for this plugin. The contributing guidelines mention them but I had trouble tracking down where the markdown files live.