Panic when dropping RawTask

DataDog / glommio

Glommio is a thread-per-core crate that makes writing highly parallel asynchronous applications in a thread-per-core architecture easier for rustaceans.

Other

3.12k stars 164 forks source link

Panic when dropping RawTask #671

Open ozgrakkurt opened 4 months ago

ozgrakkurt commented 4 months ago

Panic happens here: https://github.com/DataDog/glommio/blob/d3f6e7a2ee7fb071ada163edcf90fc3286424c31/glommio/src/task/raw.rs#L351

I couldn't get a stack trace because the issue happened on production configuration. Will have more info if it happens again.

Couldn't find a reproducer yet. I'll manually check the code a bit to see if I can find something.

ozgrakkurt commented 4 months ago

Also maybe the executor can contain the panics and not crash itself? For now I just made it abort the process if one of the executors crash because of panic.

ozgrakkurt commented 3 months ago

Seems like this is very similar to https://github.com/DataDog/glommio/issues/379

Curious if it is possible to remove the c style code from this area and just use Arc