DataDog / helm-charts

Helm charts for Datadog products
Apache License 2.0
349 stars 1.02k forks source link

Use uncompressedlayerssupport only if containerImage is enabled #1585

Closed tbavelier closed 1 month ago

tbavelier commented 1 month ago

What this PR does / why we need it:

In #1573 , datadog.sbom.containerImage.uncompressedLayersSupport was set to true to prevent errors for the SBOM feature on EKS, GKE, AKS where discard_uncompressed_layers is enabled by default. However, this feature requires CAP_SYS_ADMIN and mounts some directories that are not necessarily compatible with other distributions such as GKE Autopilot where the Daemonset can't be admitted anymore. This PR gates this default behind datadog.sbom.containerImage.enabled (false by default) to ensure we only add these modifications if and only if the user wants to use the SBOM container image feature.

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]