DataDog / libdatadog

Datadog shared rust-based library. For now only used in other products (e.g. Ruby or PHP libraries).
Apache License 2.0
48 stars 9 forks source link

[crashtracker] Small style improvements to 754 #759

Closed danielsn closed 3 days ago

danielsn commented 4 days ago

What does this PR do?

Addresses some PR comments I'd made on #754 754

Motivation

David was so fast he merged before I posted the comments.

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

pr-commenter[bot] commented 4 days ago

Benchmarks

Comparison

Benchmark execution time: 2024-11-26 19:45:56

Comparing candidate commit 72a94ce4 in PR branch dsn/crashtracker-edit-fix-poll-zombies with baseline commit 48240f25 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details ### Group 1 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|--------------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|72a94ce4 |1732649703 |dsn/crashtracker-edit-fix-poll-zombies| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |--------------------|--------------|-------|-----------------|-----------------|-------|-------|--------|--------|--------------------|--------|--------|------|-------|----|-----------| |write only interface|execution_time|1.385µs|3.268µs ± 1.458µs|3.113µs ± 0.024µs|3.133µs|3.165µs|14.352µs|15.340µs|392.72% |7.619 |57.993 |44.49%|0.103µs|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |--------------------|--------------|----------------------------------------|-------------------|------------------------|---------------| |write only interface|execution_time|[3.066µs; 3.470µs] or [-6.182%; +6.182%]|None |None |None | ### Group 2 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|--------------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|72a94ce4 |1732649703 |dsn/crashtracker-edit-fix-poll-zombies| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |--------------------------------------|--------------|-------|-----------------|-----------------|-------|-------|-------|-------|--------------------|--------|--------|-----|-------|----|-----------| |concentrator/add_spans_to_concentrator|execution_time|9.116ms|9.148ms ± 0.014ms|9.147ms ± 0.008ms|9.155ms|9.173ms|9.192ms|9.233ms|0.94% |1.671 |6.552 |0.16%|0.001ms|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |--------------------------------------|--------------|----------------------------------------|-------------------|------------------------|---------------| |concentrator/add_spans_to_concentrator|execution_time|[9.146ms; 9.150ms] or [-0.022%; +0.022%]|None |None |None | ### Group 3 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|--------------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|72a94ce4 |1732649703 |dsn/crashtracker-edit-fix-poll-zombies| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |----------------------------------------|--------------|---------|--------------------|-------------------|---------|---------|---------|---------|--------------------|--------|--------|-----|-------|----|-----------| |normalization/normalize_trace/test_trace|execution_time|297.789ns|309.698ns ± 15.345ns|303.852ns ± 3.729ns|309.594ns|344.485ns|359.965ns|363.686ns|19.69% |1.903 |2.832 |4.94%|1.085ns|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |----------------------------------------|--------------|--------------------------------------------|-------------------|------------------------|---------------| |normalization/normalize_trace/test_trace|execution_time|[307.571ns; 311.825ns] or [-0.687%; +0.687%]|None |None |None | ### Group 4 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|--------------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|72a94ce4 |1732649703 |dsn/crashtracker-edit-fix-poll-zombies| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |-----------------------|--------------|-------|-----------------|-----------------|-------|-------|-------|-------|--------------------|--------|--------|-----|-------|----|-----------| |tags/replace_trace_tags|execution_time|2.590µs|2.654µs ± 0.017µs|2.656µs ± 0.004µs|2.660µs|2.683µs|2.689µs|2.692µs|1.36% |-1.687 |4.675 |0.65%|0.001µs|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |-----------------------|--------------|----------------------------------------|-------------------|------------------------|---------------| |tags/replace_trace_tags|execution_time|[2.652µs; 2.657µs] or [-0.090%; +0.090%]|None |None |None | ### Group 5 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|--------------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|72a94ce4 |1732649703 |dsn/crashtracker-edit-fix-poll-zombies| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |----------------------------------------------|--------------|---------|-------------------|-------------------|---------|---------|---------|---------|--------------------|--------|--------|-----|-------|----|-----------| |benching string interning on wordpress profile|execution_time|149.828µs|150.931µs ± 0.336µs|150.890µs ± 0.139µs|151.026µs|151.522µs|152.196µs|153.104µs|1.47% |2.187 |10.513 |0.22%|0.024µs|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |----------------------------------------------|--------------|--------------------------------------------|-------------------|------------------------|---------------| |benching string interning on wordpress profile|execution_time|[150.884µs; 150.978µs] or [-0.031%; +0.031%]|None |None |None | ### Group 6 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|--------------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|72a94ce4 |1732649703 |dsn/crashtracker-edit-fix-poll-zombies| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |----------------------------------------------------------------------------|--------------|--------|------------------|------------------|--------|--------|--------|--------|--------------------|--------|--------|-----|-------|----|-----------| |benching deserializing traces from msgpack to their internal representation |execution_time|58.901ms|59.228ms ± 0.148ms|59.201ms ± 0.037ms|59.246ms|59.426ms|59.891ms|60.084ms|1.49% |3.006 |12.654 |0.25%|0.010ms|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |----------------------------------------------------------------------------|--------------|------------------------------------------|-------------------|------------------------|---------------| |benching deserializing traces from msgpack to their internal representation |execution_time|[59.207ms; 59.248ms] or [-0.035%; +0.035%]|None |None |None | ### Group 7 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|--------------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|72a94ce4 |1732649703 |dsn/crashtracker-edit-fix-poll-zombies| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |------------------------|--------------|--------|------------------|------------------|--------|--------|--------|--------|--------------------|--------|--------|-----|-------|----|-----------| |sql/obfuscate_sql_string|execution_time|75.066µs|75.296µs ± 0.160µs|75.287µs ± 0.047µs|75.325µs|75.420µs|75.760µs|77.174µs|2.51% |8.308 |92.612 |0.21%|0.011µs|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |------------------------|--------------|------------------------------------------|-------------------|------------------------|---------------| |sql/obfuscate_sql_string|execution_time|[75.274µs; 75.319µs] or [-0.030%; +0.030%]|None |None |None | ### Group 8 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|--------------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|72a94ce4 |1732649703 |dsn/crashtracker-edit-fix-poll-zombies| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |-----------------|--------------|--------|-------------------|------------------|--------|--------|--------|---------|--------------------|--------|--------|------|-------|----|-----------| |two way interface|execution_time|19.039µs|24.922µs ± 14.091µs|19.193µs ± 0.045µs|20.134µs|46.096µs|48.432µs|157.333µs|719.76% |5.428 |42.486 |56.40%|0.996µs|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |-----------------|--------------|------------------------------------------|-------------------|------------------------|---------------| |two way interface|execution_time|[22.969µs; 26.875µs] or [-7.836%; +7.836%]|None |None |None | ### Group 9 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|--------------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|72a94ce4 |1732649703 |dsn/crashtracker-edit-fix-poll-zombies| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |----------------------------------------------------------|--------------|-----------------|----------------------------------|----------------------------------|-----------------|-----------------|-----------------|-----------------|--------------------|--------|--------|-----|-------------|----|-----------| |credit_card/is_card_number/ |execution_time|4.622µs |4.631µs ± 0.003µs |4.630µs ± 0.002µs |4.633µs |4.636µs |4.638µs |4.649µs |0.40% |0.521 |3.379 |0.07%|0.000µs |1 |200 | |credit_card/is_card_number/ |throughput |215103277.457op/s|215947508.667op/s ± 158815.794op/s|215963793.671op/s ± 97610.980op/s |216047173.902op/s|216176114.357op/s|216341953.131op/s|216372832.027op/s|0.19% |-0.510 |3.333 |0.07%|11229.973op/s|1 |200 | |credit_card/is_card_number/ 3782-8224-6310-005 |execution_time|91.264µs |92.348µs ± 0.554µs |92.361µs ± 0.132µs |92.473µs |92.663µs |92.887µs |98.309µs |6.44% |6.941 |70.383 |0.60%|0.039µs |1 |200 | |credit_card/is_card_number/ 3782-8224-6310-005 |throughput |10172041.891op/s |10828983.011op/s ± 62404.491op/s |10827127.486op/s ± 15437.906op/s |10843531.227op/s |10907031.115op/s |10952363.876op/s |10957219.697op/s |1.20% |-6.514 |64.755 |0.57%|4412.664op/s |1 |200 | |credit_card/is_card_number/ 378282246310005 |execution_time|85.907µs |87.595µs ± 0.491µs |87.628µs ± 0.129µs |87.741µs |87.888µs |88.517µs |92.818µs |5.92% |5.848 |63.830 |0.56%|0.035µs |1 |200 | |credit_card/is_card_number/ 378282246310005 |throughput |10773793.525op/s |11416518.895op/s ± 62022.961op/s |11411927.310op/s ± 16874.682op/s |11435362.758op/s |11483614.736op/s |11547461.476op/s |11640523.232op/s |2.00% |-5.330 |57.574 |0.54%|4385.686op/s |1 |200 | |credit_card/is_card_number/37828224631 |execution_time|4.621µs |4.630µs ± 0.005µs |4.630µs ± 0.002µs |4.632µs |4.635µs |4.636µs |4.691µs |1.32% |7.484 |84.494 |0.11%|0.000µs |1 |200 | |credit_card/is_card_number/37828224631 |throughput |213163307.963op/s|215965128.892op/s ± 245570.675op/s|215983639.245op/s ± 97497.844op/s |216068893.567op/s|216228753.837op/s|216339891.666op/s|216403701.104op/s|0.19% |-7.379 |82.955 |0.11%|17364.469op/s|1 |200 | |credit_card/is_card_number/378282246310005 |execution_time|84.126µs |84.739µs ± 0.224µs |84.744µs ± 0.139µs |84.879µs |85.040µs |85.456µs |85.638µs |1.05% |0.420 |1.765 |0.26%|0.016µs |1 |200 | |credit_card/is_card_number/378282246310005 |throughput |11677041.916op/s |11801052.896op/s ± 31179.401op/s |11800202.376op/s ± 19378.180op/s |11822812.412op/s |11849553.433op/s |11877180.700op/s |11886862.056op/s |0.73% |-0.391 |1.702 |0.26%|2204.717op/s |1 |200 | |credit_card/is_card_number/37828224631000521389798 |execution_time|58.568µs |58.680µs ± 0.038µs |58.681µs ± 0.019µs |58.697µs |58.743µs |58.774µs |58.791µs |0.19% |-0.086 |0.728 |0.06%|0.003µs |1 |200 | |credit_card/is_card_number/37828224631000521389798 |throughput |17009333.449op/s |17041643.962op/s ± 11043.265op/s |17041293.596op/s ± 5440.474op/s |17047244.744op/s |17060721.869op/s |17069790.125op/s |17074199.178op/s |0.19% |0.092 |0.729 |0.06%|780.877op/s |1 |200 | |credit_card/is_card_number/x371413321323331 |execution_time|6.556µs |6.565µs ± 0.003µs |6.565µs ± 0.002µs |6.567µs |6.572µs |6.574µs |6.579µs |0.21% |0.424 |1.197 |0.05%|0.000µs |1 |200 | |credit_card/is_card_number/x371413321323331 |throughput |152009548.274op/s|152313225.721op/s ± 79835.793op/s |152322810.416op/s ± 38875.512op/s |152357412.295op/s|152438229.990op/s|152498834.960op/s|152523101.395op/s|0.13% |-0.419 |1.191 |0.05%|5645.243op/s |1 |200 | |credit_card/is_card_number_no_luhn/ |execution_time|4.621µs |4.632µs ± 0.004µs |4.631µs ± 0.002µs |4.634µs |4.638µs |4.640µs |4.641µs |0.21% |0.071 |0.138 |0.08%|0.000µs |1 |200 | |credit_card/is_card_number_no_luhn/ |throughput |215464613.528op/s|215907479.949op/s ± 174180.491op/s|215912835.988op/s ± 103283.075op/s|216013047.191op/s|216200871.174op/s|216327725.944op/s|216424408.265op/s|0.24% |-0.065 |0.139 |0.08%|12316.421op/s|1 |200 | |credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 |execution_time|69.274µs |70.399µs ± 0.319µs |70.389µs ± 0.189µs |70.590µs |70.876µs |71.129µs |71.283µs |1.27% |-0.207 |0.632 |0.45%|0.023µs |1 |200 | |credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 |throughput |14028524.208op/s |14205113.113op/s ± 64453.068op/s |14206671.433op/s ± 38129.423op/s |14241687.416op/s |14308204.783op/s |14369888.186op/s |14435374.946op/s |1.61% |0.242 |0.668 |0.45%|4557.520op/s |1 |200 | |credit_card/is_card_number_no_luhn/ 378282246310005 |execution_time|64.211µs |64.675µs ± 0.172µs |64.661µs ± 0.112µs |64.781µs |64.953µs |65.205µs |65.285µs |0.97% |0.530 |0.986 |0.27%|0.012µs |1 |200 | |credit_card/is_card_number_no_luhn/ 378282246310005 |throughput |15317414.883op/s |15461971.879op/s ± 41067.643op/s |15465241.871op/s ± 26739.599op/s |15489367.712op/s |15520530.641op/s |15544675.541op/s |15573596.143op/s |0.70% |-0.508 |0.947 |0.26%|2903.921op/s |1 |200 | |credit_card/is_card_number_no_luhn/37828224631 |execution_time|4.620µs |4.631µs ± 0.004µs |4.631µs ± 0.002µs |4.634µs |4.637µs |4.639µs |4.639µs |0.17% |-0.309 |0.147 |0.08%|0.000µs |1 |200 | |credit_card/is_card_number_no_luhn/37828224631 |throughput |215550491.006op/s|215925556.857op/s ± 170300.238op/s|215918685.033op/s ± 108177.908op/s|216019425.566op/s|216225786.293op/s|216361223.286op/s|216466506.969op/s|0.25% |0.313 |0.153 |0.08%|12042.045op/s|1 |200 | |credit_card/is_card_number_no_luhn/378282246310005 |execution_time|62.259µs |62.501µs ± 0.097µs |62.490µs ± 0.048µs |62.545µs |62.660µs |62.803µs |62.919µs |0.69% |0.665 |1.980 |0.15%|0.007µs |1 |200 | |credit_card/is_card_number_no_luhn/378282246310005 |throughput |15893458.203op/s |15999893.838op/s ± 24682.589op/s |16002465.982op/s ± 12256.353op/s |16012776.194op/s |16039284.217op/s |16054030.603op/s |16061902.573op/s |0.37% |-0.649 |1.939 |0.15%|1745.323op/s |1 |200 | |credit_card/is_card_number_no_luhn/37828224631000521389798|execution_time|58.572µs |58.681µs ± 0.037µs |58.681µs ± 0.018µs |58.697µs |58.736µs |58.783µs |58.826µs |0.25% |0.325 |1.900 |0.06%|0.003µs |1 |200 | |credit_card/is_card_number_no_luhn/37828224631000521389798|throughput |16999211.674op/s |17041392.371op/s ± 10604.081op/s |17041306.333op/s ± 5138.001op/s |17046499.986op/s |17059821.484op/s |17065670.408op/s |17073147.354op/s |0.19% |-0.318 |1.888 |0.06%|749.822op/s |1 |200 | |credit_card/is_card_number_no_luhn/x371413321323331 |execution_time|6.556µs |6.565µs ± 0.003µs |6.565µs ± 0.002µs |6.566µs |6.569µs |6.571µs |6.591µs |0.40% |2.289 |17.911 |0.05%|0.000µs |1 |200 | |credit_card/is_card_number_no_luhn/x371413321323331 |throughput |151718223.818op/s|152327081.651op/s ± 78116.864op/s |152327872.755op/s ± 36967.499op/s |152364704.718op/s|152440800.043op/s|152498011.242op/s|152534184.322op/s|0.14% |-2.267 |17.712 |0.05%|5523.696op/s |1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |----------------------------------------------------------|--------------|------------------------------------------------------------|-------------------|------------------------|---------------| |credit_card/is_card_number/ |execution_time|[4.630µs; 4.631µs] or [-0.010%; +0.010%] |None |None |None | |credit_card/is_card_number/ |throughput |[215925498.325op/s; 215969519.008op/s] or [-0.010%; +0.010%]|None |None |None | |credit_card/is_card_number/ 3782-8224-6310-005 |execution_time|[92.271µs; 92.425µs] or [-0.083%; +0.083%] |None |None |None | |credit_card/is_card_number/ 3782-8224-6310-005 |throughput |[10820334.348op/s; 10837631.673op/s] or [-0.080%; +0.080%] |None |None |None | |credit_card/is_card_number/ 378282246310005 |execution_time|[87.527µs; 87.663µs] or [-0.078%; +0.078%] |None |None |None | |credit_card/is_card_number/ 378282246310005 |throughput |[11407923.110op/s; 11425114.681op/s] or [-0.075%; +0.075%] |None |None |None | |credit_card/is_card_number/37828224631 |execution_time|[4.630µs; 4.631µs] or [-0.016%; +0.016%] |None |None |None | |credit_card/is_card_number/37828224631 |throughput |[215931095.158op/s; 215999162.626op/s] or [-0.016%; +0.016%]|None |None |None | |credit_card/is_card_number/378282246310005 |execution_time|[84.708µs; 84.770µs] or [-0.037%; +0.037%] |None |None |None | |credit_card/is_card_number/378282246310005 |throughput |[11796731.731op/s; 11805374.061op/s] or [-0.037%; +0.037%] |None |None |None | |credit_card/is_card_number/37828224631000521389798 |execution_time|[58.675µs; 58.685µs] or [-0.009%; +0.009%] |None |None |None | |credit_card/is_card_number/37828224631000521389798 |throughput |[17040113.471op/s; 17043174.452op/s] or [-0.009%; +0.009%] |None |None |None | |credit_card/is_card_number/x371413321323331 |execution_time|[6.565µs; 6.566µs] or [-0.007%; +0.007%] |None |None |None | |credit_card/is_card_number/x371413321323331 |throughput |[152302161.248op/s; 152324290.194op/s] or [-0.007%; +0.007%]|None |None |None | |credit_card/is_card_number_no_luhn/ |execution_time|[4.631µs; 4.632µs] or [-0.011%; +0.011%] |None |None |None | |credit_card/is_card_number_no_luhn/ |throughput |[215883340.208op/s; 215931619.690op/s] or [-0.011%; +0.011%]|None |None |None | |credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 |execution_time|[70.354µs; 70.443µs] or [-0.063%; +0.063%] |None |None |None | |credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 |throughput |[14196180.538op/s; 14214045.688op/s] or [-0.063%; +0.063%] |None |None |None | |credit_card/is_card_number_no_luhn/ 378282246310005 |execution_time|[64.651µs; 64.699µs] or [-0.037%; +0.037%] |None |None |None | |credit_card/is_card_number_no_luhn/ 378282246310005 |throughput |[15456280.298op/s; 15467663.459op/s] or [-0.037%; +0.037%] |None |None |None | |credit_card/is_card_number_no_luhn/37828224631 |execution_time|[4.631µs; 4.632µs] or [-0.011%; +0.011%] |None |None |None | |credit_card/is_card_number_no_luhn/37828224631 |throughput |[215901954.882op/s; 215949158.832op/s] or [-0.011%; +0.011%]|None |None |None | |credit_card/is_card_number_no_luhn/378282246310005 |execution_time|[62.487µs; 62.514µs] or [-0.021%; +0.021%] |None |None |None | |credit_card/is_card_number_no_luhn/378282246310005 |throughput |[15996473.069op/s; 16003314.608op/s] or [-0.021%; +0.021%] |None |None |None | |credit_card/is_card_number_no_luhn/37828224631000521389798|execution_time|[58.676µs; 58.686µs] or [-0.009%; +0.009%] |None |None |None | |credit_card/is_card_number_no_luhn/37828224631000521389798|throughput |[17039922.747op/s; 17042861.995op/s] or [-0.009%; +0.009%] |None |None |None | |credit_card/is_card_number_no_luhn/x371413321323331 |execution_time|[6.564µs; 6.565µs] or [-0.007%; +0.007%] |None |None |None | |credit_card/is_card_number_no_luhn/x371413321323331 |throughput |[152316255.405op/s; 152337907.897op/s] or [-0.007%; +0.007%]|None |None |None | ### Group 10 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|--------------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|72a94ce4 |1732649703 |dsn/crashtracker-edit-fix-poll-zombies| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |-------------------------------------------------------------------------------------------------------|--------------|----------------|---------------------------------|---------------------------------|----------------|----------------|----------------|----------------|--------------------|--------|--------|-----|-------------|----|-----------| |normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...|execution_time|280.284µs |280.816µs ± 0.255µs |280.786µs ± 0.161µs |280.950µs |281.224µs |281.633µs |282.033µs |0.44% |1.090 |2.966 |0.09%|0.018µs |1 |200 | |normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...|throughput |3545690.656op/s |3561056.640op/s ± 3227.003op/s |3561428.408op/s ± 2037.523op/s |3563360.106op/s |3565369.740op/s |3566525.709op/s |3567811.157op/s |0.18% |-1.080 |2.920 |0.09%|228.184op/s |1 |200 | |normalization/normalize_name/normalize_name/bad-name |execution_time|27.156µs |27.309µs ± 0.152µs |27.250µs ± 0.082µs |27.433µs |27.594µs |27.632µs |27.644µs |1.45% |0.748 |-0.846 |0.56%|0.011µs |1 |200 | |normalization/normalize_name/normalize_name/bad-name |throughput |36173668.730op/s|36618944.563op/s ± 203195.740op/s|36696711.835op/s ± 110620.188op/s|36798370.298op/s|36815517.762op/s|36820391.073op/s|36824156.074op/s|0.35% |-0.738 |-0.865 |0.55%|14368.109op/s|1 |200 | |normalization/normalize_name/normalize_name/good |execution_time|16.908µs |17.007µs ± 0.072µs |17.000µs ± 0.058µs |17.055µs |17.147µs |17.182µs |17.253µs |1.49% |0.779 |0.086 |0.42%|0.005µs |1 |200 | |normalization/normalize_name/normalize_name/good |throughput |57962083.645op/s|58800983.353op/s ± 249493.703op/s|58822907.216op/s ± 202461.820op/s|59030929.618op/s|59076050.570op/s|59109118.268op/s|59144828.044op/s|0.55% |-0.760 |0.029 |0.42%|17641.869op/s|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |-------------------------------------------------------------------------------------------------------|--------------|----------------------------------------------------------|-------------------|------------------------|---------------| |normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...|execution_time|[280.780µs; 280.851µs] or [-0.013%; +0.013%] |None |None |None | |normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...|throughput |[3560609.408op/s; 3561503.872op/s] or [-0.013%; +0.013%] |None |None |None | |normalization/normalize_name/normalize_name/bad-name |execution_time|[27.288µs; 27.330µs] or [-0.077%; +0.077%] |None |None |None | |normalization/normalize_name/normalize_name/bad-name |throughput |[36590783.588op/s; 36647105.539op/s] or [-0.077%; +0.077%]|None |None |None | |normalization/normalize_name/normalize_name/good |execution_time|[16.997µs; 17.017µs] or [-0.059%; +0.059%] |None |None |None | |normalization/normalize_name/normalize_name/good |throughput |[58766405.925op/s; 58835560.780op/s] or [-0.059%; +0.059%]|None |None |None | ### Group 11 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|--------------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|72a94ce4 |1732649703 |dsn/crashtracker-edit-fix-poll-zombies| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |-------------------------------------------------------------------------------------------------------|--------------|----------------|--------------------------------|--------------------------------|----------------|----------------|----------------|----------------|--------------------|--------|--------|-----|------------|----|-----------| |normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...|execution_time|508.543µs |509.530µs ± 0.612µs |509.425µs ± 0.320µs |509.776µs |510.387µs |511.893µs |513.886µs |0.88% |2.751 |14.321 |0.12%|0.043µs |1 |200 | |normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...|throughput |1945958.222op/s |1962594.484op/s ± 2350.110op/s |1962997.044op/s ± 1232.715op/s |1964071.528op/s |1965059.463op/s |1966173.614op/s |1966400.917op/s |0.17% |-2.720 |14.051 |0.12%|166.178op/s |1 |200 | |normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて |execution_time|465.567µs |466.450µs ± 0.405µs |466.456µs ± 0.280µs |466.701µs |467.131µs |467.485µs |468.039µs |0.34% |0.508 |0.554 |0.09%|0.029µs |1 |200 | |normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて |throughput |2136571.927op/s |2143854.133op/s ± 1860.160op/s |2143824.443op/s ± 1288.859op/s |2145259.955op/s |2146631.397op/s |2147241.195op/s |2147917.345op/s |0.19% |-0.502 |0.540 |0.09%|131.533op/s |1 |200 | |normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters |execution_time|175.868µs |176.677µs ± 0.359µs |176.660µs ± 0.232µs |176.877µs |177.303µs |177.491µs |177.685µs |0.58% |0.115 |-0.066 |0.20%|0.025µs |1 |200 | |normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters |throughput |5627947.895op/s |5660057.412op/s ± 11483.865op/s |5660599.953op/s ± 7445.194op/s |5668126.235op/s |5679938.762op/s |5685024.375op/s |5686070.915op/s |0.45% |-0.104 |-0.071 |0.20%|812.032op/s |1 |200 | |normalization/normalize_service/normalize_service/[empty string] |execution_time|45.124µs |45.361µs ± 0.106µs |45.347µs ± 0.061µs |45.419µs |45.560µs |45.640µs |45.662µs |0.69% |0.423 |-0.011 |0.23%|0.008µs |1 |200 | |normalization/normalize_service/normalize_service/[empty string] |throughput |21899912.121op/s|22045402.332op/s ± 51629.049op/s|22052054.735op/s ± 29861.429op/s|22076718.568op/s|22125958.265op/s|22147354.034op/s|22161034.018op/s|0.49% |-0.410 |-0.023 |0.23%|3650.725op/s|1 |200 | |normalization/normalize_service/normalize_service/test_ASCII |execution_time|41.914µs |42.099µs ± 0.121µs |42.087µs ± 0.053µs |42.141µs |42.240µs |42.310µs |43.367µs |3.04% |5.887 |58.586 |0.29%|0.009µs |1 |200 | |normalization/normalize_service/normalize_service/test_ASCII |throughput |23058966.181op/s|23753696.618op/s ± 67168.519op/s|23760258.469op/s ± 29643.834op/s|23788963.033op/s|23827533.103op/s|23847379.666op/s|23858229.575op/s|0.41% |-5.668 |55.546 |0.28%|4749.532op/s|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |-------------------------------------------------------------------------------------------------------|--------------|----------------------------------------------------------|-------------------|------------------------|---------------| |normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...|execution_time|[509.446µs; 509.615µs] or [-0.017%; +0.017%] |None |None |None | |normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...|throughput |[1962268.782op/s; 1962920.187op/s] or [-0.017%; +0.017%] |None |None |None | |normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて |execution_time|[466.394µs; 466.506µs] or [-0.012%; +0.012%] |None |None |None | |normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて |throughput |[2143596.332op/s; 2144111.933op/s] or [-0.012%; +0.012%] |None |None |None | |normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters |execution_time|[176.628µs; 176.727µs] or [-0.028%; +0.028%] |None |None |None | |normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters |throughput |[5658465.858op/s; 5661648.965op/s] or [-0.028%; +0.028%] |None |None |None | |normalization/normalize_service/normalize_service/[empty string] |execution_time|[45.346µs; 45.376µs] or [-0.032%; +0.032%] |None |None |None | |normalization/normalize_service/normalize_service/[empty string] |throughput |[22038247.043op/s; 22052557.622op/s] or [-0.032%; +0.032%]|None |None |None | |normalization/normalize_service/normalize_service/test_ASCII |execution_time|[42.082µs; 42.116µs] or [-0.040%; +0.040%] |None |None |None | |normalization/normalize_service/normalize_service/test_ASCII |throughput |[23744387.707op/s; 23763005.529op/s] or [-0.039%; +0.039%]|None |None |None | ### Group 12 |cpu_model |git_commit_sha|git_commit_date|git_branch | |----------------------------------------------|--------------|---------------|--------------------------------------| |Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz|72a94ce4 |1732649703 |dsn/crashtracker-edit-fix-poll-zombies| |scenario |metric |min |mean ± sd |median ± mad |p75 |p95 |p99 |max |peak_to_median_ratio|skewness|kurtosis|cv |sem |runs|sample_size| |----------------------------|--------------|--------|------------------|------------------|--------|--------|--------|--------|--------------------|--------|--------|-----|-------|----|-----------| |redis/obfuscate_redis_string|execution_time|37.668µs|38.234µs ± 1.002µs|37.758µs ± 0.045µs|37.910µs|40.370µs|40.436µs|41.448µs|9.77% |1.701 |1.026 |2.61%|0.071µs|1 |200 | |scenario |metric |95% CI mean |Shapiro-Wilk pvalue|Ljung-Box pvalue (lag=1)|Dip test pvalue| |----------------------------|--------------|------------------------------------------|-------------------|------------------------|---------------| |redis/obfuscate_redis_string|execution_time|[38.095µs; 38.373µs] or [-0.363%; +0.363%]|None |None |None |

Baseline

Omitted due to size.

codecov-commenter commented 4 days ago

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 70.53%. Comparing base (48240f2) to head (72a94ce). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #759 +/- ## ======================================= Coverage 70.53% 70.53% ======================================= Files 297 297 Lines 43487 43484 -3 ======================================= Hits 30673 30673 + Misses 12814 12811 -3 ``` | [Components](https://app.codecov.io/gh/DataDog/libdatadog/pull/759/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | Coverage Δ | | |---|---|---| | [crashtracker](https://app.codecov.io/gh/DataDog/libdatadog/pull/759/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `44.86% <0.00%> (+0.04%)` | :arrow_up: | | [crashtracker-ffi](https://app.codecov.io/gh/DataDog/libdatadog/pull/759/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `8.41% <ø> (ø)` | | | [datadog-alloc](https://app.codecov.io/gh/DataDog/libdatadog/pull/759/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `98.73% <ø> (ø)` | | | [data-pipeline](https://app.codecov.io/gh/DataDog/libdatadog/pull/759/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `89.09% <ø> (ø)` | | | [data-pipeline-ffi](https://app.codecov.io/gh/DataDog/libdatadog/pull/759/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `0.00% <ø> (ø)` | | | [ddcommon](https://app.codecov.io/gh/DataDog/libdatadog/pull/759/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `83.46% <ø> (ø)` | | | [ddcommon-ffi](https://app.codecov.io/gh/DataDog/libdatadog/pull/759/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `69.12% <ø> (ø)` | | | [ddtelemetry](https://app.codecov.io/gh/DataDog/libdatadog/pull/759/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `59.05% <ø> (ø)` | | | [ddtelemetry-ffi](https://app.codecov.io/gh/DataDog/libdatadog/pull/759/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `22.13% <ø> (ø)` | | | [dogstatsd](https://app.codecov.io/gh/DataDog/libdatadog/pull/759/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `89.45% <ø> (ø)` | | | [dogstatsd-client](https://app.codecov.io/gh/DataDog/libdatadog/pull/759/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `79.77% <ø> (ø)` | | | [ipc](https://app.codecov.io/gh/DataDog/libdatadog/pull/759/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `82.76% <ø> (ø)` | | | [profiling](https://app.codecov.io/gh/DataDog/libdatadog/pull/759/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `84.30% <ø> (ø)` | | | [profiling-ffi](https://app.codecov.io/gh/DataDog/libdatadog/pull/759/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `77.46% <ø> (ø)` | | | [serverless](https://app.codecov.io/gh/DataDog/libdatadog/pull/759/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `0.00% <ø> (ø)` | | | [sidecar](https://app.codecov.io/gh/DataDog/libdatadog/pull/759/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `38.01% <ø> (ø)` | | | [sidecar-ffi](https://app.codecov.io/gh/DataDog/libdatadog/pull/759/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `0.00% <ø> (ø)` | | | [spawn-worker](https://app.codecov.io/gh/DataDog/libdatadog/pull/759/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `50.36% <ø> (ø)` | | | [tinybytes](https://app.codecov.io/gh/DataDog/libdatadog/pull/759/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `94.77% <ø> (ø)` | | | [trace-mini-agent](https://app.codecov.io/gh/DataDog/libdatadog/pull/759/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `72.36% <ø> (ø)` | | | [trace-normalization](https://app.codecov.io/gh/DataDog/libdatadog/pull/759/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `98.23% <ø> (ø)` | | | [trace-obfuscation](https://app.codecov.io/gh/DataDog/libdatadog/pull/759/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `95.77% <ø> (ø)` | | | [trace-protobuf](https://app.codecov.io/gh/DataDog/libdatadog/pull/759/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `77.67% <ø> (ø)` | | | [trace-utils](https://app.codecov.io/gh/DataDog/libdatadog/pull/759/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DataDog) | `93.29% <ø> (ø)` | |