search

DataDog / serverless-plugin-datadog

Serverless plugin to automagically instrument your Lambda functions with Datadog
Apache License 2.0
96 stars 49 forks source link

Rollback dd extension version change #462

Closed Fodoj closed 9 months ago

Fodoj commented 9 months ago

For some reason, this commit changed DD Extension version for 7 AWS Regions: https://github.com/DataDog/serverless-plugin-datadog/commit/d8613513146b25530a53d173d47037f4a82b28ea

DD Extension 54 doesn't exist yet: https://github.com/DataDog/datadog-lambda-extension/releases and thus all deployments in those regions with 5.57.0 plugin version are broken:

{
    "errorType": "Extension.LaunchError",
    "errorMessage": "RequestId: XXXXX Error: fork/exec /opt/extensions/datadog-agent: exec format error"
}
astuyve commented 9 months ago

Hi, thanks for reaching out. It does look like extension v54 was partially released somehow, however that error message indicates it is indeed present, but has applied the incorrect architecture for your chose lambda function (ie: x86 when arm64 is selected or vice-versa).

We'll investigate right away, but this rollback PR won't be correct. We'll need to raise a new one

astuyve commented 9 months ago

Closing in favor of https://github.com/DataDog/serverless-plugin-datadog/pull/463

Fodoj commented 9 months ago

How's my PR was incorrect then, if new one is an exact copy 😂 Anyway, thanks for quickly fixing this!

astuyve commented 9 months ago

My sincerest apologies @Fodoj, when I first looked at your PR this morning I was on my phone and believed your PR reverted the entire change to layers.json. I had clicked your attached git sha, not your actual changes.

Instead of going back and forth on github, I thought it would be fastest to do the surgery myself. It was my own fault for not carefully reading your contribution, and I apologize for that oversight.

I'm grateful that you took the time to write up this report and submit the PR, although I must confess I still can't reproduce the exec format issue you've raised using extension v54. Can you share some reproduction steps?

Thanks again!