DataDog / yubikey

YubiKey at Datadog
MIT License
495 stars 36 forks source link

expects/expect-ubuntu.sh hanging forever due to wrong string #112

Closed EdTheBearded closed 1 year ago

EdTheBearded commented 1 year ago

Was trying to setup my Yubikey on Ubuntu, and noticed it was hanging forever when it reached the step:

GnuPG needs to construct a user ID to identify your key.                                                                                                                                                           

Real name: Eduardo Ferreira                                                                              
Email address: 

Inspecting the script expects/expect-ubuntu.sh I noticed that the string it is expecting is expect -exact "E-mail address: ".

Noticed that there were 2 more steps where it was hanging forever:

diff --git a/expects/expect-ubuntu.sh b/expects/expect-ubuntu.sh
index 39c280e..be470ef 100755
--- a/expects/expect-ubuntu.sh
+++ b/expects/expect-ubuntu.sh
@@ -179,13 +179,13 @@ send -- "y\r"
 expect -exact "Real name: "
 send -- "$REALNAME\r"

-expect -exact "E-mail address: "
+expect -exact "Email address: "
 send -- "$EMAIL\r"

 expect -exact "Comment: "
 send -- "$COMMENT\r"

-expect -exact "Change (N)ame, (C)omment, (E)-mail or (O)kay/(Q)uit? "
+expect -exact "Change (N)ame, (C)omment, (E)mail or (O)kay/(Q)uit? "
 send -- "O\r"

 # Send new Admin PIN
@@ -241,7 +241,7 @@ expect -exact "Enter Admin PIN: "
 stty -echo
 send -- "$ADMIN_PIN\r"

-expect -exact "Set touch policy of ENC key to on? \[y/N\]: "
+expect -exact "Set touch policy of DEC key to on? \[y/N\]: "
 send -- "y\r"
 expect eof
daisukixci commented 1 year ago

Thank you for reporting, i will fix tomorrow