Fix cube dimensions - Githubissues

DataJunction / dj

A metrics platform.

http://datajunction.io

MIT License

35 stars 15 forks source link

Fix cube dimensions #1138

Closed shangyian closed 3 months ago

shangyian commented 3 months ago

Summary

There's a bug with creating cubes that have dimension attributes that share the same column name but come from different dimension nodes. This is due to a "group by" we do on the column name that shouldn't be done.

Test Plan

Locally

[ ] PR has an associated issue: #
[x] make check passes
[x] make test shows 100% unit test coverage

Deployment Plan

N/A

netlify[bot] commented 3 months ago

Deploy Preview for thriving-cassata-78ae72 canceled.

Name	Link
Latest commit	5812a128285289a4247d6a1658bb9fc5dc198fdb
Latest deploy log	https://app.netlify.com/sites/thriving-cassata-78ae72/deploys/66b6247c2519f700088ba8b7