Migrate to the new query builder for metrics SQL and data endpoints

shangyian commented 3 months ago

Summary

This PR migrates to the v2 query build for the metrics /sql and /data endpoints. This change is part of a series of changes that are needed to move all of the endpoints we use to generate SQL based on DJ nodes to use the v2 query builder. The v2 builder is more robust and generally has fewer type inference errors, so instead of going back and fixing type inference issues with the old build, we can just move to the new one.

Some other issues this PR fixes include:

If we're using a materialized table for a given DJ node, we should choose the right engine based on the available ones for the materialized table's catalog.
For cubes: if we're building a query from a materialized measures table, then we should rewrite the metric queries to use the measures from the materialized table. If we're instead building a query from a materialized metrics table, then we should just use a generic aggregator (sum) and select the metrics and dimensions of interest from that table directly.

Test Plan

[ ] PR has an associated issue: #1148
[ ] make check passes
[ ] make test shows 100% unit test coverage

Deployment Plan

netlify[bot] commented 3 months ago

Deploy Preview for thriving-cassata-78ae72 canceled.

Name	Link
Latest commit	b29cadef967413ab7df3d4de2edb0fba64d2c397
Latest deploy log	https://app.netlify.com/sites/thriving-cassata-78ae72/deploys/66d711ec50f9bb0008f86b7e

shangyian commented 2 months ago

@agorajek I fixed most of the tests.. ended up skipping a few that weren't relevant anymore, since it should be largely covered by the existing tests.

DataJunction / dj