DataJunction / dj

A metrics platform.
http://datajunction.io
MIT License
35 stars 15 forks source link

After a node's query is updated, we should revalidate dimension links #1164

Closed shangyian closed 2 months ago

shangyian commented 2 months ago

Summary

When any node with a query is updated, we should revalidate the node's dimension links, as some of them may have become invalidated due to the updated query. For example, if a transform's query gets updated to remove a column that has a dimension link defined on it, we should also remove the dimension link.

To fix it for existing nodes, I've added some changes to the POST /nodes/{node}/validate endpoint so that it does the same logic of cleaning up unneeded dimension links.

Test Plan

Deployment Plan

netlify[bot] commented 2 months ago

Deploy Preview for thriving-cassata-78ae72 canceled.

Name Link
Latest commit 34a6a51567f89e94888b14284e759a017ba62adb
Latest deploy log https://app.netlify.com/sites/thriving-cassata-78ae72/deploys/66e13db6e192d7000844d1c7