In some cases, DJ nodes are created (in draft mode) that don't have any valid upstream nodes, thus making it so that we can't infer an appropriate catalog for the node. We seem to default to catalog_id = 0 for these invalid nodes, which causes issues since this catalog is never updated after the node becomes valid. This PR adds a default catalog for nodes that don't have an inferrable catalog at creation time.
Summary
In some cases, DJ nodes are created (in draft mode) that don't have any valid upstream nodes, thus making it so that we can't infer an appropriate catalog for the node. We seem to default to
catalog_id = 0
for these invalid nodes, which causes issues since this catalog is never updated after the node becomes valid. This PR adds a default catalog for nodes that don't have an inferrable catalog at creation time.Test Plan
Locally
make check
passesmake test
shows 100% unit test coverageDeployment Plan
ASAP