DataJunction / dj

A metrics platform.
http://datajunction.io
MIT License
35 stars 15 forks source link

Add default catalog setting for DJ nodes #1167

Closed shangyian closed 2 months ago

shangyian commented 2 months ago

Summary

In some cases, DJ nodes are created (in draft mode) that don't have any valid upstream nodes, thus making it so that we can't infer an appropriate catalog for the node. We seem to default to catalog_id = 0 for these invalid nodes, which causes issues since this catalog is never updated after the node becomes valid. This PR adds a default catalog for nodes that don't have an inferrable catalog at creation time.

Test Plan

Locally

Deployment Plan

ASAP

netlify[bot] commented 2 months ago

Deploy Preview for thriving-cassata-78ae72 canceled.

Name Link
Latest commit 48007f5afc4c35835bdd3c60a47503020979176a
Latest deploy log https://app.netlify.com/sites/thriving-cassata-78ae72/deploys/66df85a9d31559000891a63b