Closed agorajek closed 1 month ago
Name | Link |
---|---|
Latest commit | 56d892746aebc1eb28e5ca61fd4ed394c37795aa |
Latest deploy log | https://app.netlify.com/sites/thriving-cassata-78ae72/deploys/67044a0ec8507f0008825977 |
Changes largely LGTM!
Only one comment:
Made the above flag default to False everywhere. It used to be True on the node, which I think is not great default.
@agorajek From what I've seen, a lot of people seem to rely on this flag being
true
... of course we can announce that this is a breaking change, but I'm wondering if that's just the default behavior that people expect or prefer?
@shangyian I am worried that the current setup (created_node --> update_if_exists=True) will lead to silent overrides. I think I could do the following:
create_node( ..., update_if_exists: default False)
and create_or_update_node( ..., update_if_exists: default True)
This should make it easy for users to pick the expected behavior easily. cc @anhqle Thoughts?
I'm good with changing the default of
update_if_exists
to False.In that case, it'd be nice to tell user about the
update_if_exists
functionality when they run into node-already-exists-error.
Yes, we have that already, example:
datajunction.exceptions.DJClientException: Node `default.account_type_table` already exists. Use `update_if_exists=True` to update the node.
Summary
Few things in this PR:
update_if_exists
flag to namespace and tag creation.Test Plan
Unit tests and my local examples.
make check
passesmake test
shows 100% unit test coverageDeployment Plan
Asap.