search

DataTables / FixedHeader

Fix the header, footer, left or right columns of a table in place, to always show them when scrolling
http://www.datatables.net/
Other
75 stars 83 forks source link

Fixed header shouldn't print #69

Closed joe-meyer closed 9 years ago

DataTables commented 9 years ago

Very good point - thanks for the PR. This should be in the other styles as well. I'm happy to include it or take an updated PR.

Are you happy for this to be released under the MIT license?

joe-meyer commented 9 years ago

I'm fine with it being released under MIT.

Also, i'm not super familiar with SASS / SCSS yet, but is it possible to have a base file and simply override styles as needed and then simply release compiled versions of each? Seems kind of odd to duplicate code across 4 different files. But if you'd like I can certainly update the other files (or you can merge and do it yourself really makes no difference to me).

DataTables commented 9 years ago

What I've done with some of the other extensions is to have a common.scss file which has the common styles and can just be included in all 4 styling files. The Buttons repo uses this if you'd like to make that change.

joe-meyer commented 9 years ago

@DataTables ok for now I just updated the other SCSS files, the common might make more sense in the future if more common styles get added.

DataTables commented 9 years ago

Sounds fair - thanks for the PR.