search

Datatamer / tamr-client

Programmatically interact with Tamr
https://tamr-client.readthedocs.io
Apache License 2.0
11 stars 25 forks source link

Address review comments for the new tamr-client continuous mastering tutorial #470

Closed lamagnifica closed 4 years ago

lamagnifica commented 4 years ago

https://github.com/Datatamer/tamr-client/pull/469#pullrequestreview-518076196

@pcattori @skalish FYI

skalish commented 4 years ago

@lamagnifica I've created a follow-up PR addressing some of these requested changes here #471. If there are more changes to be made, I'm happy to make them. I would also say (though @pcattori can disagree here) that there is no pressure to rush this, since it isn't blocking anything from being merged.

In fact, in the future this is maybe the best mode of operation. We can merge tutorials and other field-written documentation after a brief review and iterate with more detailed feedback and revision with a polishing PR that can stay open as long as is necessary.