search

Datavault-UK / automate-dv

A free to use dbt package for creating and loading Data Vault 2.0 compliant Data Warehouses (powered by dbt, an open source data engineering tool, registered trademark of dbt Labs)
https://www.automate-dv.com
Apache License 2.0
478 stars 114 forks source link

Very basic Greenplum support #138

Closed enchantner closed 1 year ago

enchantner commented 1 year ago

Maybe it isn't such a good idea, but I see a lot of people using Greenplum for building Data Vault. However, most of them just create a fork from master branch and then rewrite the "defaults" to Greenplum/PostgreSQL manually.

I know you guys are already working on postgres support, so this request is just an attempt to take part and help those people trying to build DV on GP.

DVAlexHiggs commented 1 year ago

Hi! Thanks so much for this. This is not something we can currently merge or accept because we're still working on the contribution architecture and process, sorry about that. The thing that's missing are guides on how to properly execute our extensive test suite, which is vital for any PRs and contributions to be accepted.

I will leave this open for other peoples benefit and for when we eventually can provide better contribution guidance and support. Until then, please feel free to keep updating this PR if you choose to.

Thanks again

johnoscott commented 1 year ago

@enchantner I am currently working on PostgreSQL support for dbtvault and will eagerly review this work to inform what I am doing. Thanks for the contribution. Maybe we can circle back once I am done and test it with Greenplum ?

DVAlexHiggs commented 1 year ago

@enchantner, @johnoscott has been working closely with us to deliver a tested Postgres implementation, so he is in a good position to help. Please tag me or grab me on slack if there's any support I can provide. I'm really excited to get community contributions off the ground, it's nothing but beneficial to everyone!

P.S. All tests have passed so you at least haven't broken anything in the current implementations! What we need is to get those tests running on Greenplum

andrew-terekhov commented 1 year ago

Thanks for work @enchantner Waiting for Greenplum support!

@DVAlexHiggs Do you need any help?