search

Datavault-UK / automate-dv

A free to use dbt package for creating and loading Data Vault 2.0 compliant Data Warehouses (powered by dbt, an open source data engineering tool, registered trademark of dbt Labs)
https://www.automate-dv.com
Apache License 2.0
478 stars 114 forks source link

[BUG] Query tags not being set in insert_by_period materialisation #195

Open NiallRees opened 1 year ago

NiallRees commented 1 year ago

It looks as though query tags aren't being set anywhere in the insert_by_period materialization (haven't checked others). In the dbt-snowflake adapter, these are set here: https://github.com/dbt-labs/dbt-snowflake/blob/main/dbt/include/snowflake/macros/materializations/incremental.sql#L61

AB#5360

DVAlexHiggs commented 1 year ago

Hello. Thanks for this report!

I believe this is layover from the fact we based our custom materialisations on a now quite old and defunct version of the core dbt incremental materialisation (which didn't originally do anything with tags) and they are due a much-needed refresh.

We shall add it to the backlog!

NiallRees commented 1 year ago

Cheers @DVAlexHiggs! Hope you're keeping well

NiallRees commented 1 year ago

For more context, our package uses some query tag metadata.