DavHau / pypi-deps-db

Dependency DB for python packages on pypi
MIT License
66 stars 40 forks source link

Why are we parsing ourselves #24

Open TyberiusPrime opened 1 year ago

TyberiusPrime commented 1 year ago

There's probably a good reason that I don't know about, but whey are we parsing like every sdist and wheel, when we could ask the pypi json api - at least in the first place, with a fallback to 'parse it yourself'?

DavHau commented 1 year ago

I'm not sure to be honest. It's a while since I implemented this. It's possible that I missed something, or that the data we're interested in wasn't available at that time through the API. Feel free to improve it.

InLaw commented 1 year ago

I hope I'm not totally wrong .. wasn't a reason that the meta/data was/is not equal?

https://github.com/posativ/isso/blob/0.12.6.2/setup.py#L46 vs https://pypi.org/pypi/isso/0.12.6.2/json # without install_requires

e.g. "xlsxwriter (>=1.4.3) ; extra == 'all'" # would need a different parser?