David-Desmaisons / DiscogsClient

Discogs API C# Client
MIT License
41 stars 16 forks source link

Subtrack in tracklist #6

Closed traponto closed 6 years ago

traponto commented 6 years ago

Is there a way to get subtracks of an 'Index' track? For example: in Pink Floyd Atom Heart Mother I have the track 'Atom Heart Mother' ('Index' track) with subtracks 1.a / 1.f

Sample.zip

David-Desmaisons commented 6 years ago

Is that information provided by dsicogs API?

traponto commented 6 years ago

referring to the example given above, seems that if the subtracks belong to a 'heading' type track they are extracted correctly. If instead they belong to an 'index' type track, these are not extracted. The release [r2678791] reports the first case and your client reports them correctly, the release [r11464584] reports the second case and in this case they are not extracted.

traponto commented 6 years ago

Here a json example where you can see a tracklist with 'index' track and the 'sub_tracks' that belong to it

2106643_json.zip

David-Desmaisons commented 6 years ago

What is the corresponding query/url?

traponto commented 6 years ago

https://api.discogs.com/releases/2106643

David-Desmaisons commented 6 years ago

Thanks, I will provide

David-Desmaisons commented 6 years ago

Corrected in version 2.1.0

SyndicateOfSwing commented 6 years ago

Hello David; Would you be interested in some custom dev work based on Discogs API ? Kind regards, Gregory Lacour Elypsia Records

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10


From: David Desmaisons notifications@github.com Sent: Thursday, March 29, 2018 1:50:13 AM To: David-Desmaisons/DiscogsClient Cc: Subscribed Subject: Re: [David-Desmaisons/DiscogsClient] Subtrack in tracklist (#6)

Closed #6https://github.com/David-Desmaisons/DiscogsClient/issues/6.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/David-Desmaisons/DiscogsClient/issues/6#event-1546828264, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ab_dwMDKzcQeKTdoXEFSs987NmH28OHiks5tjCG1gaJpZM4S6NwE.

traponto commented 6 years ago

Sorry, I performed a test on last release and now I find the sub_track, but these could have in turn 'extraartists' that are not reported instead; attached a compressed file that includes what is returned from the Discogs site and what is present in your DiscogsRelease class. Furthermore, the 'Text' field may be present in 'Formats'. Even if off-topic I try to ask if it is possible to make public a method that starting from url (and not from DiscogsImage) can extract the image present in the 'Thumb' field (now I extract it creating an instance of DiscogsImage)

traponto commented 6 years ago

9093776_json.zip

David-Desmaisons commented 6 years ago

1) extraartists => added in version 2.2.0

2) DiscogsImage => not currently in my plans

traponto commented 6 years ago

okay thanks