DavidDeSimone / OpenCloudSaves

A tool used for syncing your save games across your devices
MIT License
346 stars 8 forks source link

New game definitions created on Steam Deck not being recreated on PC installation #80

Open dc-grimm opened 1 year ago

dc-grimm commented 1 year ago

Hi David,

I created a definition for syncing god of war ps2 and some other emulated games on the Steam Deck.

When Syncing on pc these don't get created.

DavidDeSimone commented 1 year ago

This is an area I am trying to improve in 0.18 - try opening the app on windows, waiting a few seconds, and then restarting the app on windows.

The issue if that while we do sync game definitions across the platforms, we don't refresh the UI when that operation is complete, which can lead to user confusion.

it is also possible there is a bug in the sync logic, but I'd like to start with that step first.

dc-grimm commented 1 year ago

ps. I tried downloading the user_overrides.json from the cloud and replaced it in %appdata%\OpenCloudSave but that seems to be the default game list without updates.

DavidDeSimone commented 1 year ago

ps. I tried downloading the user_overrides.json from the cloud and replaced it in %appdata%\OpenCloudSave but that seems to be the default game list without updates.

Hmmmm, so that means that your user_overrides didn't update to the cloud. I'll investigate this more. For now, you may need to recreate the definition across your devices - sorry about that!

dc-grimm commented 1 year ago

Update: After a few syncs on the Deck and manual adding it to the PC one its now showing the new entries.

It seems that the sync on the pc takes way longer than on the deck though

dc-grimm commented 1 year ago

Okay. It was still busy simulating so I killed it. I think I broke it image

dc-grimm commented 1 year ago

Seems like its listing everything from windows, users/username, program files +x86, and other folders.

I suspect its because I have an empty path in one of my definitions. I couldn't manage to remove it with the interface so I deleted it from the json.

Will retest.

DavidDeSimone commented 1 year ago

yeah good catch - it may have been defaulting to a "root" path so it was syncing everything under the sun. That is a bad footgun, and I'll add some more protections around that.

Sorry you are having these issues! I'll work to try and correct some of these rough edges for next release.

dc-grimm commented 1 year ago

Na man. No problem. Its all good. Having this tool is already a win, and helping to make it better makes it even better. Unfortunately I don't have the skills you are employing here or I would have loved to help more.

Btw. I had trouble installing it on pc. It just popped up a cmd window and closed without options.

Not sure how it finally got installed to be honest. I opened the installer with zip and ran the application from extracted and after that I found it installed under program files. So that might be something else to also look at in future.

DavidDeSimone commented 1 year ago

For some guardrails on large syncs, we will now have this:

Screenshot 2023-03-09 at 8 07 16 PM Screenshot 2023-03-09 at 8 07 08 PM

I've also put a cap on log files to prevent them from blowing up to a huge size.

hicwic commented 1 year ago

the file user_overrides.json doesn't seems to sync for me too. The one on my drive appear to be the original one. for now i'll try to recreate definition on each device

DavidDeSimone commented 1 year ago

This slid to 0.19, but is still on my RADAR

DavidDeSimone commented 1 year ago

So I figured out the root cause - even though I was syncing user_overrides.json, I was writing to it right before the cloud sync operation. So user_override would always have a newer timestamp compared to what was on the cloud, and it would not sync (and often get in weird states).

gingerr commented 11 months ago

Stumbled upon the same problem when trying out OpenCloudSaves to sync Zelda BotW between Steam Deck and PC. I will attempt next to sync the user_overrides.json manually once i localized it on the steam deck.

Do you plan to build and distribute a new OpenCloudSaves version which includes #104 ?

Thank you for OpenCloudSaves!