search

DavidT3 / XGA

X-ray: Generate and Analyse is a module designed to make the analysis of XMM observations simple and efficient. It provides an interface with SAS for the creation of XMM data products, as well as a way to easily perform fits (scalable for multiple observations) and retrieve information about an object, all within a Python package.
BSD 3-Clause "New" or "Revised" License
31 stars 3 forks source link

Some profile generation isn't checking for existing matching profiles properly? #514

Open DavidT3 opened 3 years ago

DavidT3 commented 3 years ago

Running inv_abel_dens_onion_temp multiple times for bug checking is generating many EM, temp, and density profiles.

DavidT3 commented 3 years ago

A problem which I suspect is related is that if you delete the profiles but have a profile fitted in XSPEC it will not make a new profile on re-run, and XGA will not find a matching temperature profile when you run the mass function.

DavidT3 commented 3 years ago

Actually, I think its because in the onion_deproj_temp_prof function, I don't check for existing, matching, 3D temperature profiles already stored within the source. So it just builds another one, should be very easy to fix.