search

DavidePastore / Slim-Validation

A validation library for the Slim Framework. It internally uses Respect/Validation.
170 stars 30 forks source link

Slim 4 support #55

Closed M-Shahbaz closed 1 year ago

M-Shahbaz commented 4 years ago

Please update for slim 4 support and also respect version to 2 Thanks,

DavidePastore commented 4 years ago

Hi @M-Shahbaz . Thanks for you PR but I see that most of the tests don't work correctly. You have to be sure to also update the Slim version used in the composer.json file and the logic behind tests.

M-Shahbaz commented 4 years ago

Hi @DavidePastore . Thanks for your response, I'll try to update asap.

marcogermani87 commented 3 years ago

@DavidePastore please merge @M-Shahbaz fix, thanks

DavidePastore commented 3 years ago

Hi @necrox87. I can't merge this PR because the build process failed. It's necessary to fix tests.

willbonde commented 2 years ago

Is this still just needing tests updated so they pass?

DavidePastore commented 2 years ago

Hi @willbonde. Yes, tests are still necessary.

DavidePastore commented 1 year ago

Superseded by https://github.com/DavidePastore/Slim-Validation/pull/61