search

DazedNConfused- / CDDA-Game-Launcher

A Cataclysm: Dark Days Ahead launcher with additional features
MIT License
74 stars 11 forks source link

Linux port #90

Open AriaMoradi opened 1 year ago

AriaMoradi commented 1 year ago

As discussed in https://github.com/remyroy/CDDA-Game-Launcher/issues/329 this project really can use a linux port.

AriaMoradi commented 1 year ago

I am working on merging work non destructively from https://github.com/PassionateAngler/CDDA-Game-Launcher to the code base, it removes windows support and adds Linux support but it's possible to have both worlds work with each other, I wonder if it's fine if we add Linux support to this project albeit limited in features at least from the start? This might open the door to macOS support also?

DazedNConfused- commented 1 year ago

Howdy!

Thanks for the interest and for the work done so far! Given the complexity of the launcher and the currently-working feature set, I cannot endorse adding incomplete support for a new platform (as in, merging partial support where some things worked and some other things broke). Everything would need to work out of the box, and the parts that didn't would at the very least have to be properly disabled in a way that a potential user had no doubts the feature under scrutiny is still unsupported and not just outright broken due to a bug. I also believe this would require extensive testing in order to not leave any proverbial stone unturned (as in, an enabled button, table, or any other GUI element that worked in Windows but not in Linux).

We would also have to make sure that adding/fixing Linux stuff didn't break Windows stuff, which would involve massive regression testing each time. In a codebase with 0 unit tests, this labor would have to be done entirely manually. I don't think anyone is going to be taking this mantle up (and I for one don't even play on Windows/Linux anymore! 😅)

So yup, I understand the pains of playing CDDA in a launcher-unsupported platform. God knows I got so frustrated myself that I had to make my own separate launcher just for MacOS: https://github.com/DazedNConfused-/macata-launcher. I wonder if the massive costs such a merge would incur are worth the potentially negligible userbase for Remy's launcher that is in Linux and not using https://github.com/qrrk/Catapult already.