search

Deadly0 / final-form-material-ui

A set of wrapper components to facilitate using Material UI with Final Form
92 stars 33 forks source link

helperText is just for errors #22

Open dbonabhealth opened 5 years ago

dbonabhealth commented 5 years ago

In TextField, there is this code: helperText={showError ? meta.error || meta.submitError : undefined} that basically ignores any initial value of helperText.

Is there any reason not to have the code like: helperText={showError ? meta.error || meta.submitError : rest.helperText} ...or something to that effect?

I apologize if I violated your guidelines for requesting a feature.

optyler commented 4 years ago

IMO, we need to split this two things appart.

The component used is MuiFormHelperText and display error messages, then, the variant prop should be error right ? But if we use the helper text as a real helper, the variant error should not be used...