Decathlon / vitamin-compose

Decathlon Design System UI components for Compose applications
https://www.decathlon.design
Apache License 2.0
267 stars 29 forks source link

feat: add access to popup properties from DropdownMenu #31

Open berrehailb opened 2 years ago

berrehailb commented 2 years ago

Is your feature request related to a problem? Please describe. I was needing to have the same functionality that AutoCompleteTextView but using Vitamin Compose. But I can't access to PopupProperties because it's not targetable using VitaminMenus.Dropdown.

Modify the PopupProperties will enables me to change the default properties from focusable to not focusable in order to continue to type text even if dropdown is appearing.

Describe the solution you'd like I would like to have the possibility to define my own PopupProperties from VitaminMenus.Dropdown.

GerardPaligot commented 2 years ago

We have a text input component with a dropdown docked (VitaminTextInputs. OutlinedDropdown(...) (doc) and VitaminTextInputs.FilledDropdown (doc)) but I think this component doesn't fit your need too because the text input isn't editable (according to the design specification).

We should be able to improve this last component to fit your needs but we need to improve first the design specification of the component if the design system team is okay with that. ping @SimonLeclercq @Sabrinavigil @MARIEDELATTRE

ManonPolle commented 1 year ago

@MARIEDELATTRE @Sabrinavigil @SimonLeclercq lets talk about it in grooming session

lauthieb commented 1 year ago

Validated in grooming session by @Decathlon/design-system-core-team-design

lauthieb commented 1 year ago

@ManonPolle to create on vitamin-android repo too