Decathlon / vitamin-ios

Decathlon Design System UI components for iOS & iPadOS applications
https://www.decathlon.design
Apache License 2.0
46 stars 14 forks source link

feat: swiftui vitamin textfield #100

Closed florentlotthepro closed 1 year ago

florentlotthepro commented 1 year ago

Changes description

Add text input component to SwiftUI.

Context

Checklist

Does this introduce a breaking change?

Screenshots

iPhone

Outlined Filled
Simulator Screen Shot - iPhone 14 - 2022-12-08 at 16 06 46 Simulator Screen Shot - iPhone 14 - 2022-12-08 at 16 06 52

iPad

Outlined Filled
Simulator Screen Shot - iPad Pro (9 7-inch) - 2022-12-08 at 16 08 01 Simulator Screen Shot - iPad Pro (9 7-inch) - 2022-12-08 at 16 08 05

Other information

Co-authored-by: @MBarantal Co-authored-by: @baptistedajon

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

florentlotthepro commented 1 year ago

@daniel-dumortier It's a wanted behavior to have not editable TextField in the "states" section 😅 Because the purpose is to show all states of the TextField and not test them. To test them there is the "dynamic" section.

I'm not really sure about the password use case because I think it's not a recommended way to do it for Apple. Indeed in SwiftUI, there is no built-in option to switch from secure mode to no secure mode (like it's done in UIKit). Apple used to display the last letter in a readable way to avoid the need to toggle between a secure and not secure mode.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

florentlotthepro commented 1 year ago

Feedback from the design review:

The color of the placeholders here seems very clear, I'm not sure if it is "content tertiary"?

It's a system color that we cannot customize -> Need a design update for iOS.

Ready to merge ✅