feat: chip implementation for uikit

Decathlon / vitamin-ios

Decathlon Design System UI components for iOS & iPadOS applications

https://www.decathlon.design

Apache License 2.0

46 stars 14 forks source link

feat: chip implementation for uikit #111

Closed daniel-dumortier closed 1 year ago

daniel-dumortier commented 1 year ago

Changes description

This PR adds the Chip component for UIKit version.

Context

Implements the UIKit part of issue #20

Checklist

[x] Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
[x] Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
[x] Check your code additions will fail neither code linting checks.
[ ] I have reviewed the submitted code.
[x] I have tested on an iPhone device/simulator.
[x] I have tested on an iPad device/simulator.
[ ] If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Does this introduce a breaking change?

Screenshots

iPhone

Simulator Screen Shot - iPhone 8 - 2023-01-18 at 14 05 04

iPad

Simulator Screen Shot - iPad (9th generation) - 2023-01-18 at 14 05 57

Other information

SimonLeclercq commented 1 year ago

@daniel-dumortier, I have some issues with the current chips: 1 - filter variant display a tag on iOS sample, but it's not required on this platform. 2 - I'm not able to close an input-chips. I don't know if it's due to the sample or if it's not provided.

Thanks ☺️

daniel-dumortier commented 1 year ago

@SimonLeclercq Regarding filter variant: Do you mean a badge(and not a tag) ? Honestly, there were two sources, and I did not know which one was the good one:

Decathlon design site : https://www.decathlon.design/726f8c765/p/08dbe1-chip/b/459b4b
Figma : https://www.figma.com/file/cmZCNVet64UlDNnDDd4hDV/Vitamin---iOS-14-UI-kit-(v0)?node-id=2869%3A8916&t=ZTudhFTyZgF3GOFt-0

I decided to implement the more complex one ;). Before reverting my code, can you confirm that Figma is the source of truth (and eventually update ZeroHeight) ?

Regarding the input variant : All variant can be provided with an action callback that will be launched when user taps the chip. I thought it was a better idea to let the responsibility of the dismissal of the input chip within this callback to the app developer. But I you think it should be an intrinsic behavior of this component, that's ok for me, i'll dismiss the chip ans execute the callback just after.

SimonLeclercq commented 1 year ago

@daniel-dumortier yes I mean badge, excuse me.

Well noted regarding the two sources of truth, I'll take this point. Issue here: https://github.com/Decathlon/vitamin-design/issues/191

I'll take a look a callback and give you more detail as soon as possible 😀

daniel-dumortier commented 1 year ago

@SimonLeclercq Done, the badge has been removed, you can find the last showcase on slack