feat: SegmentedControl UIKit implementation

daniel-dumortier commented 1 year ago

Changes description

Implementation of Vitamin tab component for UIKit. It is a subclass of standard UISegmentedControl, with only customization of:

text style and color
shadow

The PR also contains a VitaminTabsController that handles a common use case : display a VitaminTabs at the top of the screen, and a viewController below, depending on the tab selected

Context

UIKit part of #41

Checklist

[x] Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
[x] Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
[x] Check your code additions will fail neither code linting checks.
[x] I have reviewed the submitted code.
[x] I have tested on an iPhone device/simulator.
[x] I have tested on an iPad device/simulator.
[x] If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Does this introduce a breaking change?

No

Screenshots

iPhone

Simulator Screen Shot - iPhone 8 - 2023-02-06 at 23 22 55

iPad

Simulator Screen Shot - iPad (9th generation) - 2023-02-06 at 23 23 59

Other information

I named the component VitaminTab, but I wonder if it should not been named VitaminSegmentedControl, that would be more understandable by iOS developers.

SimonLeclercq commented 1 year ago

Hey @daniel-dumortier, Feel free to discuss with @florentlotthepro about the component name. Keep in mind that we want to stay as close as possible to the developer's experience of the platform. On the Design side, this component is named segmented control.

SimonLeclercq commented 1 year ago

@daniel-dumortier I'm not able to find the bitrise link 🤔 Can you help me? 😎

daniel-dumortier commented 1 year ago

@SimonLeclercq the showcase has not been built yet, that's why you can't find the link ;) Since I added a new feature on this branch following @florentlotthepro 's suggestion (in short, a generic screen that handles the display of other sub-screens depending on the segment selected), I wait for other code owners technical review before submitting it to you (to ensure it is clean on a code point of view)

daniel-dumortier commented 1 year ago

@SimonLeclercq The build is available, you can find the link on Slack

daniel-dumortier commented 1 year ago

@SimonLeclercq Honestly, I do not really get what you mean by horizontal shift, but for info, I just styled the native SegmentedControl component (with custom font, size, colors, and shadow), thus I do not have any way to shift or move the labels in the segmented control. I just let iOS place them inside the component.