Decathlon / vitamin-ios

Decathlon Design System UI components for iOS & iPadOS applications
https://www.decathlon.design
Apache License 2.0
46 stars 14 forks source link

fix: snackbar label width miscomputed when image is set #118

Closed daniel-dumortier closed 1 year ago

daniel-dumortier commented 1 year ago

Changes description

In some circumstances, then label of a snackbar with an image can be truncated with '...' characters at the end. It depends on the length of the message, that should be a specific lenght (not too short, not too long), that's why it has not been detected earlier

I took advantage of this PR to add completion on display() and dismiss() methods of VitaminSnackbar as requested by a team that uses the snackbar without the UIViewController extension.

Context

Closes #117

Checklist

Does this introduce a breaking change?

Screenshots

iPhone

Simulator Screen Shot - iPhone 8 - 2023-02-12 at 21 19 05

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

daniel-dumortier commented 1 year ago

Sorry, I spotted two errors in documentation, and fixed them. That should be the last one before merge ;)